8000 fix: fix multiple import problem by JoanFM · Pull Request #3276 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix multiple import problem #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2021
Merged

fix: fix multiple import problem #3276

merged 3 commits into from
Aug 27, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Aug 27, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner August 27, 2021 08:01
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/jaml component/peapod labels Aug 27, 2021
tadejsv
tadejsv reviewed Aug 27, 2021
View reviewed changes
@codecov
Copy link
codecov bot commented Aug 27, 2021 •
edited
Loading

Codecov Report

Merging #3276 (c1b8a72) into master (ff2f9a3) will increase coverage by 1.26%.
The diff coverage is 98.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3276      +/-   ##
==========================================
+ Coverage   89.13%   90.39%   +1.26%     
==========================================
  Files         148      148              
  Lines       10468    10489      +21     
==========================================
+ Hits         9331     9482     +151     
+ Misses       1137     1007     -130
Flag Coverage Δ
daemon 44.49% <64.17%> (-0.12%) ⬇️
jina 90.38% <98.50%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/__init__.py 100.00% <ø> (+13.79%) ⬆️
jina/parsers/deprecated.py 83.33% <ø> (ø)
jina/peapods/pods/__init__.py 86.58% <ø> (-0.13%) ⬇️
jina/peapods/pods/compound.py 90.34% <50.00%> (ø)
jina/clients/base/__init__.py 92.42% <100.00%> (ø)
jina/clients/base/grpc.py 70.21% <100.00%> (+6.38%) ⬆️
jina/clients/base/http.py 93.18% <100.00%> (+4.54%) ⬆️
jina/clients/base/websocket.py 86.36% <100.00%> (ø)
jina/flow/base.py 89.70% <100.00%> (+11.38%) ⬆️
jina/importer.py 87.17% <100.00%> (-0.63%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb3286...c1b8a72. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 27, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 977, delta to last 2 avg.: -25%
  • 🐢🐢 query QPS at 40, delta to last 2 avg.: -28%
  • 🐢🐢 dam extend QPS at 41279, delta to last 2 avg.: -32%
  • 🐢🐢 avg flow time within 1.8268 seconds, delta to last 2 avg.: +41%
  • 🐎🐎🐎🐎 import jina within 0.439 seconds, delta to last 2 avg.: +27%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 977 40 41279 1.8268 0.439
2.0.20 1198 50 58522 1.4484 0.3845
2.0.19 1425 61 63588 1.1266 0.3042

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as draft August 27, 2021 08:25
@JoanFM
Copy link
Contributor Author
JoanFM commented Aug 27, 2021

Still tests to be added

@JoanFM JoanFM linked an issue Aug 27, 2021 that may be closed by this pull request
Jina performs multiple imports #3271
Closed
@JoanFM JoanFM marked this pull request as ready for review August 27, 2021 12:27
8000 @github-actions github-actions bot added size/M area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing and removed size/S labels Aug 27, 2021
@JoanFM JoanFM requested a review from tadejsv August 27, 2021 12:51
tadejsv
tadejsv suggested changes Aug 27, 2021
View reviewed changes
Copy link
Contributor
@tadejsv tadejsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the thing with removing uses_* does not work well yet. I added this test to your PR

def test_single_import_metas(patched_path_import):
    flow = Flow().add(
        uses='ExecutorImportedOnce',
        uses_metas=dict(py_modules=['executors/executor_fails_import_twice.py']),
    )
    with flow:
        pass

and it fails.

@JoanFM JoanFM requested a review from tadejsv August 27, 2021 15:07
tadejsv
tadejsv approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor
@tadejsv tadejsv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it merged, but in general I do not have a good feeling about how a single class is trying to be a loader for everything right (with load_config ) now - it leads to configs with no known structure, it's just chaotic

@JoanFM
Copy link
Contributor Author
JoanFM commented Aug 27, 2021

Let's get it merged, but in general I do not have a good feeling about how a single class is trying to be a loader for everything right (with load_config ) now - it leads to configs with no known structure, it's just chaotic

yes it is. We will refactor at some point

@JoanFM JoanFM merged commit 07f7636 into master Aug 27, 2021
@JoanFM JoanFM deleted the fix-multiple-imports branch August 27, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadejsv tadejsv tadejsv approved these changes

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

@alanthssss alanthssss Awaiting requested review from alanthssss

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/jaml component/peapod size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jina performs multiple imports
2 participants
@JoanFM @tadejsv
0