8000 fix(dam): warning truncate doc id by numb3r3 · Pull Request #3264 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(dam): warning truncate doc id #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2021
Merged

fix(dam): warning truncate doc id #3264

merged 1 commit into from
Aug 28, 2021

Conversation

numb3r3
Copy link
Member
@numb3r3 numb3r3 commented Aug 25, 2021

address #3260

@numb3r3 numb3r3 requested a review from a team as a code owner August 25, 2021 07:51
@numb3r3 numb3r3 requested review from maateen and JoanFM August 25, 2021 07:51
@numb3r3 numb3r3 linked an issue Aug 25, 2021 that may be closed by this pull request
throw a warning if the length of doc.id is larger than the key_length #3260
Closed
@numb3r3 numb3r3 requested a review from alaeddine-13 August 25, 2021 07:51
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/type labels Aug 25, 2021
hanxiao
hanxiao requested changes Aug 25, 2021
View reviewed changes
Copy link
Member
@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this behavior is not memmap specific

@codecov
Copy link
codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #3264 (bb6f943) into master (caf132d) will increase coverage by 1.90%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
+ Coverage   88.43%   90.34%   +1.90%     
==========================================
  Files         148      148              
  Lines       10402    10404       +2     
==========================================
+ Hits         9199     9399     +200     
+ Misses       1203     1005     -198
Flag Coverage Δ
daemon 44.88% <33.33%> (+<0.01%) ⬆️
jina 90.33% <66.66%> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jin 8000 a/types/arrays/memmap.py 94.62% <66.66%> (-0.31%) ⬇️
jina/logging/profile.py 98.36% <0.00%> (-0.02%) ⬇️
jina/peapods/pods/__init__.py 86.70% <0.00%> (+0.30%) ⬆️
jina/peapods/zmq/__init__.py 89.04% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (+1.02%) ⬆️
jina/peapods/runtimes/gateway/prefetch.py 95.06% <0.00%> (+1.23%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+1.26%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 96.36% <0.00%> (+1.81%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf132d...bb6f943. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1227, delta to last 2 avg.: +4%
  • 😶 query QPS at 49, delta to last 2 avg.: -2%
  • 😶 dam extend QPS at 50960, delta to last 2 avg.: +0%
  • 😶 avg flow time within 1.697 seconds, delta to last 2 avg.: +12%
  • 😶 import jina within 0.3901 seconds, delta to last 2 avg.: +4%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1227 49 50960 1.697 0.3901
2.0.20 1205 52 56532 1.5246 0.3809
2.0.19 1146 48 44388 1.4951 0.3637

Backed by latency-tracking. Further commits will update this comment.

@JoanFM
Copy link
Contributor
JoanFM commented Aug 25, 2021

@hanxiao no other object has this key length.

@alaeddine-13
Copy link
Contributor

LGTM

@hanxiao hanxiao merged commit cb16849 into master Aug 28, 2021
@hanxiao hanxiao deleted the fix-dam-keylengh branch August 28, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@maateen maateen Awaiting requested review from maateen

@JoanFM JoanFM Awaiting requested review from JoanFM

@alaeddine-13 alaeddine-13 Awaiting requested review from alaeddine-13

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/type size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

throw a warning if the length of doc.id is larger than the key_length
4 participants
@numb3r3 @JoanFM @alaeddine-13 @hanxiao
0