8000 refactor(helper): make progressbar more useful and modern by hanxiao · Pull Request #3238 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(helper): make progressbar more useful and modern #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2021
Merged

refactor(helper): make progressbar more useful and modern #3238

merged 2 commits into from
Aug 22, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Aug 22, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner August 22, 2021 10:32
@hanxiao hanxiao requested review from maateen and JoanFM August 22, 2021 10:32
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/logging labels Aug 22, 2021
@codecov
Copy link
codecov bot commented Aug 22, 2021 •
edited
Loading

Codecov Report

Merging #3238 (20c3cd1) into master (fcf17a9) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
- Coverage   90.49%   90.25%   -0.24%     
==========================================
  Files         148      148              
  Lines       10347    10375      +28     
==========================================
+ Hits         9363     9364       +1     
- Misses        984     1011      +27
Flag Coverage Δ
daemon 44.22% <13.79%> (+1.36%) ⬆️
jina 90.24% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helloworld/chatbot/app.py 83.67% <100.00%> (ø)
jina/helloworld/fashion/helper.py 90.81% <100.00%> (ø)
jina/helloworld/multimodal/app.py 86.27% <100.00%> (ø)
jina/logging/profile.py 98.33% <100.00%> (+0.89%) ⬆️
jina/jaml/parsers/executor/legacy.py 73.77% <0.00%> (-19.68%) ⬇️
jina/parsers/deprecated.py 83.33% <0.00%> (-16.67%) ⬇️
jina/peapods/peas/__init__.py 86.30% <0.00%> (-4.17%) ⬇️
jina/peapods/runtimes/gateway/http/__init__.py 97.14% <0.00%> (-2.86%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 91.42% <0.00%> (-1.91%) ⬇️
jina/peapods/pods/compound.py 90.41% <0.00%> (-1.37%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31273bd...20c3cd1. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 22, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1482, delta to last 2 avg.: +11%
  • 🐎🐎🐎🐎 query QPS at 45, delta to last 2 avg.: +33%
  • 🐎🐎🐎🐎 dam extend QPS at 60260, delta to last 2 avg.: +25%
  • 🐎🐎🐎🐎 avg flow time within 1.2043 seconds, delta to last 2 avg.: -26%
  • 😶 import jina within 0.3834 seconds, delta to last 2 avg.: -1%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1482 45 60260 1.2043 0.3834
2.0.19 1209 36 39197 1.9485 0.412
2.0.18 1460 30 57031 1.316 0.3665

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 91be0f7 into master Aug 22, 2021
@hanxiao hanxiao deleted the refator-progress-bar branch August 22, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maateen maateen Awaiting requested review from maateen

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/logging size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0