8000 fix: fix listview insert, append by JoanFM · Pull Request #3212 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix listview insert, append #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2021
Merged

fix: fix listview insert, append #3212

merged 3 commits into from
Aug 18, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Aug 18, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner August 18, 2021 15:12
@JoanFM JoanFM linked an issue Aug 18, 2021 that may be closed by this pull request
bug: appending to list in document tags #3209
Closed
@JoanFM JoanFM mentioned this pull request Aug 18, 2021
Closed
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Aug 18, 2021
@codecov
Copy link
codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #3212 (0ccde0f) into master (f44e6c9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3212      +/-   ##
==========================================
+ Coverage   90.21%   90.24%   +0.02%     
==========================================
  Files         147      147              
  Lines       10326    10328       +2     
==========================================
+ Hits         9316     9320       +4     
+ Misses       1010     1008       -2
Flag Coverage Δ
daemon 42.84% <25.00%> (-0.01%) ⬇️
jina 90.23% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.12% <100.00%> (ø)
jina/types/list.py 100.00% <100.00%> (+2.43%) ⬆️
jina/peapods/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c4944...0ccde0f. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 18, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1364, delta to last 2 avg.: -11%
  • 🐎🐎🐎🐎 query QPS at 41, delta to last 2 avg.: +11%
  • 🐎🐎🐎🐎 dam extend QPS at 45715, delta to last 2 avg.: -19%
  • 🐎🐎🐎🐎 avg flow time within 1.8672 seconds, delta to last 2 avg.: +25%
  • 🐎🐎 import jina within 0.3551 seconds, delta to last 2 avg.: +9%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1364 41 45715 1.8672 0.3551
2.0.19 1271 37 40844 1.3972 0.3815
2.0.18 1824 35 72763 1.569 0.2697

Backed by latency-tracking. Further commits will update this comment.

JoanFM
JoanFM commented Aug 18, 2021
View reviewed changes
Yongxuanzhang
Yongxuanzhang reviewed Aug 18, 2021
View reviewed changes
@Yongxuanzhang
fix: update tests/unit/types/test_list_view.py
96ae473 
Co-authored-by: Yongxuan Zhang <44033547+Yongxuanzhang@users.noreply.github.com>
JoanFM
JoanFM commented Aug 18, 2021
View reviewed changes
@JoanFM JoanFM merged commit 21a3dfa into master Aug 18, 2021
@JoanFM JoanFM deleted the fix-listview-insert branch August 18, 2021 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@hanxiao hanxiao hanxiao approved these changes

@BastinJafari BastinJafari Awaiting requested review from BastinJafari

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@jakobkruse1 jakobkruse1 Awaiting requested review from jakobkruse1

@slettner slettner Awaiting requested review from slettner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: appending to list in document tags
3 participants
@JoanFM @hanxiao @Yongxuanzhang
0