8000 fix: add jina-bot to the cla whitelist by nan-wang · Pull Request #3216 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add jina-bot to the cla whitelist #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

fix: add jina-bot to the cla whitelist #3216

merged 1 commit into from
Aug 19, 2021

Conversation

nan-wang
Copy link
Member

add jina-bot to the cla whitelist

@nan-wang nan-wang requested a review from hanxiao as a code owner August 19, 2021 04:27
@github-actions
Copy link

This PR closes: #1

@github-actions
Copy link

Jina CLA check

❤️ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you sign our Contributor License Agreement. You can sign it by commenting in format below.

I have read the CLA Document and I hereby sign the CLA

@github-actions github-actions bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Aug 19, 2021
@codecov
Copy link
codecov bot commented Aug 19, 2021 •
edited
Loading

Codecov Report

Merging #3216 (9df6c4d) into master (21a3dfa) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3216      +/-   ##
==========================================
- Coverage   90.21%   90.18%   -0.03%     
==========================================
  Files         147      147              
  Lines       10328    10328              
==========================================
- Hits         9317     9314       -3     
- Misses       1011     1014       +3
Flag Coverage Δ
daemon 42.84% <ø> (-0.02%) ⬇️
jina 90.17% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 91.42% <0.00%> (-1.91%) ⬇️
jina/peapods/peas/__init__.py 90.47% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea006d...9df6c4d. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1713, delta to last 2 avg.: +11%
  • 🐎🐎🐎🐎 query QPS at 52, delta to last 2 avg.: +30%
  • 🐎🐎🐎🐎 dam extend QPS at 63161, delta to last 2 avg.: +14%
  • 🐎🐎🐎🐎 avg flow time within 1.2169 seconds, delta to last 2 avg.: -12%
  • 🐢🐢 import jina within 0.3006 seconds, delta to last 2 avg.: -9%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1713 52 63161 1.2169 0.3006
2.0.19 1724 52 63584 1.2443 0.3046
2.0.18 1358 27 46766 1.5467 0.3583

Backed by latency-tracking. Further commits will update this comment.

@hanxiao
Copy link
Member
hanxiao commented Aug 19, 2021

cla branch not master

@hanxiao hanxiao merged commit 664bf1a into master Aug 19, 2021
@hanxiao hanxiao deleted the fix-add-whiltelist-cla-1 branch August 19, 2021 05:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hanxiao hanxiao hanxiao approved these changes

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nan-wang @hanxiao
0