8000 feat: blobs property by JoanFM · Pull Request #3198 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: blobs property #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2021
Merged

feat: blobs property #3198

merged 2 commits into from
Aug 18, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Aug 18, 2021

No description provided.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase component/type labels Aug 18, 2021
@codecov
Copy link
10000
codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #3198 (8bb48fd) into master (befb7cd) will increase coverage by 0.02%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3198      +/-   ##
==========================================
+ Coverage   90.04%   90.06%   +0.02%     
==========================================
  Files         147      147              
  Lines       10317    10331      +14     
==========================================
+ Hits         9290     9305      +15     
+ Misses       1027     1026       -1
Flag Coverage Δ
daemon 42.86% <47.82%> (+<0.01%) ⬆️
jina 90.05% <91.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/memmap.py 94.92% <ø> (ø)
jina/types/arrays/document.py 87.91% <91.30%> (-0.14%) ⬇️
jina/peapods/runtimes/gateway/http/__init__.py 97.14% <0.00%> (-2.86%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 95.06% <0.00%> (+1.23%) ⬆️
jina/clients/base/grpc.py 70.21% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update befb7cd...8bb48fd. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 18, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1449, delta to last 2 avg.: +4%
  • 🐎🐎🐎🐎 query QPS at 44, delta to last 2 avg.: +59%
  • 🐎🐎🐎🐎 dam extend QPS at 56267, delta to last 2 avg.: +13%
  • 🐎🐎🐎🐎 avg flow time within 1.2363 seconds, delta to last 2 avg.: -19%
  • 😶 import jina within 0.3642 seconds, delta to last 2 avg.: -2%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1449 44 56267 1.2363 0.3642
2.0.18 1289 25 44347 1.8182 0.3941
2.0.17 1496 29 54720 1.2708 0.3527

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as ready for review August 18, 2021 06:50
@JoanFM JoanFM requested a review from a team as a code owner August 18, 2021 06:50
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Aug 18, 2021
@JoanFM JoanFM linked an issue Aug 18, 2021 that may be closed by this pull request
Embeddings optimization #3170
Closed
3 tasks
@JoanFM JoanFM mentioned this pull request Aug 18, 2021
Closed
3 tasks
@JoanFM JoanFM requested review from bwanglzu and davidbp August 18, 2021 06:51
davidbp
davidbp approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor
@davidbp davidbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit 2939170 into master Aug 18, 2021
@JoanFM JoanFM deleted the blobs-property branch August 18, 2021 07:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidbp davidbp davidbp approved these changes

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@imsergiy imsergiy Awaiting requested review from imsergiy

@bwanglzu bwanglzu Awaiting requested review from bwanglzu

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embeddings optimization
2 participants
@JoanFM @davidbp
0