8000 fix: traverse chunk match by alaeddine-13 · Pull Request #3179 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: traverse chunk match #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2021
Merged

fix: traverse chunk match #3179

merged 2 commits into from
Aug 17, 2021

Conversation

alaeddine-13
Copy link
Contributor

closes #3068

@alaeddine-13 alaeddine-13 requested a review from a team as a code owner August 17, 2021 07:09
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Aug 17, 2021
@alaeddine-13 alaeddine-13 force-pushed the fix-traverse-chunk-match branch from ee7954b to b14ad8c Compare August 17, 2021 07:10
@codecov
Copy link
codecov bot commented Aug 17, 2021 •
edited
Loading

Codecov Report

Merging #3179 (b14ad8c) into master (8c68f75) will decrease coverage by 0.06%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3179      +/-   ##
==========================================
- Coverage   90.09%   90.03%   -0.07%     
==========================================
  Files         147      147              
  Lines       10269    10274       +5     
==========================================
- Hits         9252     9250       -2     
- Misses       1017     1024       +7
Flag Coverage Δ
daemon 42.79% <62.50%> (+0.01%) ⬆️
jina 90.02% <87.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/traversable.py 94.44% <75.00%> (-2.62%) ⬇️
jina/types/arrays/document.py 87.98% <100.00%> (+0.17%) ⬆️
jina/types/arrays/memmap.py 93.98% <100.00%> (ø)
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 91.42% <0.00%> (-1.91%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.82% <0.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58866a9...b14ad8c. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 17, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1702, delta to last 2 avg.: +13%
  • 🐎🐎🐎🐎 query QPS at 49, delta to last 2 avg.: +53%
  • 🐎🐎🐎🐎 dam extend QPS at 63799, delta to last 2 avg.: +8%
  • 🐎🐎🐎🐎 avg flow time within 1.5682 seconds, delta to last 2 avg.: +6%
  • 🐢🐢 import jina within 0.3061 seconds, delta to last 2 avg.: -10%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1702 49 63799 1.5682 0.3061
2.0.18 1474 31 56976 1.2904 0.3624
2.0.17 1533 32 60440 1.6476 0.3254

Backed by latency-tracking. Further commits will update this comment.

JoanFM
JoanFM approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor
@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@hanxiao hanxiao merged commit cb809d8 into master Aug 17, 2021
@hanxiao hanxiao deleted the fix-traverse-chunk-match branch August 17, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@mapleeit mapleeit Awaiting requested review from mapleeit

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

traverse_flat does not wok on ChunkArray or MatchArray
3 participants
@alaeddine-13 @JoanFM @hanxiao
0