8000 fix(daemon): hub cache env var by deepankarm · Pull Request #3175 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(daemon): hub cache env var #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2021
Merged

fix(daemon): hub cache env var #3175

merged 1 commit into from
Aug 16, 2021

Conversation

deepankarm
Copy link
Contributor

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner August 16, 2021 15:19
@deepankarm deepankarm linked an issue Aug 16, 2021 that may be closed by this pull request
Enable hub caching in JinaD #2936
Closed
@codecov
Copy link
codecov bot commented Aug 16, 2021 •
edited
Loading

Codecov Report

Merging #3175 (5ec000f) into master (25bb903) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3175      +/-   ##
==========================================
- Coverage   90.09%   90.05%   -0.04%     
==========================================
  Files         147      147              
  Lines       10254    10264      +10     
==========================================
+ Hits         9238     9243       +5     
- Misses       1016     1021       +5
Flag Coverage Δ
daemon 42.78% <ø> (-0.05%) ⬇️
jina 90.04% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.82% <0.00%> (-1.24%) ⬇️
jina/helper.py 79.54% <0.00%> (-0.38%) ⬇️
jina/types/arrays/neural_ops.py 90.47% <0.00%> (-0.09%) ⬇️
jina/math/distance.py 96.77% <0.00%> (ø)
jina/types/arrays/search_ops.py 100.00% <0.00%> (ø)
jina/helloworld/fashion/my_executors.py 93.15% <0.00%> (ø)
jina/math/helper.py 91.66% <0.00%> (+0.23%) ⬆️
jina/enums.py 96.00% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25bb903...5ec000f. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1384, delta to last 2 avg.: -19%
  • 😶 query QPS at 37, delta to last 2 avg.: +4%
  • 😶 dam extend QPS at 45472, delta to last 2 avg.: -30%
  • 😶 avg flow time within 1.7915 seconds, delta to last 2 avg.: +48%
  • 🐎🐎🐎🐎 import jina within 0.3493 seconds, delta to last 2 avg.: +13%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1384 37 45472 1.7915 0.3493
2.0.18 1718 35 65655 1.2596 0.3123
2.0.17 1719 35 64898 1.1578 0.3006

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 2a3ac6b into master Aug 16, 2021
@hanxiao hanxiao deleted the daemon-hub-cache branch August 16, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@jakobkruse1 jakobkruse1 Awaiting requested review from jakobkruse1

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable hub caching in JinaD
2 participants
@deepankarm @hanxiao
0