8000 refactor: no copy on append by JoanFM · Pull Request #3148 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: no copy on append #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2021
Merged

refactor: no copy on append #3148

merged 2 commits into from
Aug 11, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Aug 11, 2021 •
edited
Loading

Regading how append to Matches behave, I do not see any point on offering copy option. I think is better to add it to the list, and then edit afterwards

@JoanFM JoanFM requested a review from a team as a code owner August 11, 2021 07:05
@JoanFM JoanFM requested review from imsergiy and jakobkruse1 August 11, 2021 07:05
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/type labels Aug 11, 2021
@codecov
Copy link
codecov bot commented Aug 11, 2021 •
edited
Loading

Codecov Report

Merging #3148 (bd5df79) into master (0263d30) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
+ Coverage   89.13%   89.24%   +0.11%     
==========================================
  Files         145      145              
  Lines        9928     9922       -6     
==========================================
+ Hits         8849     8855       +6     
+ Misses       1079     1067      -12
Flag Coverage Δ
daemon 43.26% <22.22%> (+0.03%) ⬆️
jina 89.23% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/chunk.py 92.00% <100.00%> (+2.71%) ⬆️
jina/types/arrays/match.py 94.73% <100.00%> (-0.72%) ⬇️
jina/types/arrays/neural_ops.py 90.52% <100.00%> (ø)
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.15% <0.00%> (-1.37%) ⬇️
jina/hubble/helper.py 85.51% <0.00%> (ø)
jina/peapods/peas/__init__.py 86.74% <0.00%> (+0.60%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 94.17% <0.00%> (+1.94%) ⬆️
jina/hubble/hubio.py 63.54% <0.00%> (+4.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0263d30...bd5df79. Read the comment docs.

@JoanFM JoanFM marked this pull request as draft August 11, 2021 08:23
davidbp
davidbp approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor
@davidbp davidbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1272, delta to last 2 avg.: -14%
  • 🐎🐎 query QPS at 33, delta to last 2 avg.: +9%
  • 🐎🐎 dam extend QPS at 44553, delta to last 2 avg.: -18%
  • 🐎🐎 avg flow time within 1.365 seconds, delta to last 2 avg.: -21%
  • 🐎🐎🐎🐎 import jina within 0.3902 seconds, delta to last 2 avg.: +13%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1272 33 44553 1.365 0.3902
2.0.18 1742 36 65414 1.5014 0.2968
2.0.17 1243 24 43333 1.9647 0.3891

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM requested a review from hanxiao August 11, 2021 09:17
@JoanFM JoanFM marked this pull request as ready for review August 11, 2021 09:52
@hanxiao hanxiao merged commit ab16cee into master Aug 11, 2021
@hanxiao hanxiao deleted the append-no-copy branch August 11, 2021 13:06
@CatStark CatStark mentioned this pull request Aug 13, 2021
Closed
@hanxiao hanxiao mentioned this pull request Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbp davidbp davidbp approved these changes

@imsergiy imsergiy Awaiting requested review from imsergiy

@jakobkruse1 jakobkruse1 Awaiting requested review from jakobkruse1

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @davidbp @hanxiao
0