8000 test: refactor test by JoanFM · Pull Request #3132 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: refactor test #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2021
Merged

test: refactor test #3132

merged 2 commits into from
Aug 10, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Aug 9, 2021

No description provided.

@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Aug 9, 2021
@codecov
Copy link
codecov 8000 bot commented Aug 9, 2021 •
edited
Loading

Codecov Report

Merging #3132 (cf02424) into master (9745d8d) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3132      +/-   ##
==========================================
+ Coverage   89.15%   89.24%   +0.09%     
==========================================
  Files         145      145              
  Lines        9928     9928              
==========================================
+ Hits         8851     8860       +9     
+ Misses       1077     1068       -9
Flag Coverage Δ
daemon 43.23% <ø> (-0.03%) ⬇️
jina 89.23% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 92.23% <0.00%> (-1.95%) ⬇️
jina/peapods/runtimes/zmq/zed.py 94.35% <0.00%> (+0.51%) ⬆️
jina/peapods/pods/compound.py 91.78% <0.00%> (+1.36%) ⬆️
jina/peapods/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.85%) ⬆️
jina/peapods/peas/__init__.py 90.36% <0.00%> (+4.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9745d8d...cf02424. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 9, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1351, delta to last 2 avg.: -15%
  • 🐢🐢 query QPS at 25, delta to last 2 avg.: -37%
  • 🐢🐢 dam extend QPS at 46580, delta to last 2 avg.: -38%
  • 🐢🐢 avg flow time within 1.3558 seconds, delta to last 2 avg.: -16%
  • 🐎🐎🐎🐎 import jina within 0.3769 seconds, delta to last 2 avg.: +23%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1351 25 46580 1.3558 0.3769
2.0.16 1777 47 84128 1.4391 0.2924
2.0.15 1415 32 66587 1.7987 0.3183

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/M and removed size/S labels Aug 10, 2021
@JoanFM JoanFM marked this pull request as ready for review August 10, 2021 07:25
@JoanFM JoanFM requested a review from a team as a code owner August 10, 2021 07:25
@JoanFM JoanFM requested review from mapleeit and davidbp August 10, 2021 07:25
@hanxiao hanxiao merged commit e709835 into master Aug 10, 2021
@hanxiao hanxiao deleted the refactor-test-small branch August 10, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@mapleeit mapleeit Awaiting requested review from mapleeit

@davidbp davidbp Awaiting requested review from davidbp

Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @hanxiao @alaeddine-13
0