8000 fix(hubble): docker pull progressbar by numb3r3 · Pull Request #3136 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(hubble): docker pull progressbar #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2021
Merged

fix(hubble): docker pull progressbar #3136

merged 4 commits into from
Aug 10, 2021

Conversation

numb3r3
Copy link
Member
@numb3r3 numb3r3 commented Aug 10, 2021

No description provided.

@numb3r3 numb3r3 requested a review from a team as a code owner August 10, 2021 05:00
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Aug 10, 2021
@numb3r3 numb3r3 requested review from alaeddine-13, hanxiao, JoanFM and tadejsv and removed request for maateen and BastinJafari August 10, 2021 05:01
@codecov
Copy link
codecov bot commented Aug 10, 2021 •
edited
Loading

Codecov Report

Merging #3136 (0cfb590) into master (7394523) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3136      +/-   ##
==========================================
+ Coverage   89.13%   89.23%   +0.10%     
==========================================
  Files         145      145              
  Lines        9928     9928              
==========================================
+ Hits         8849     8859      +10     
+ Misses       1079     1069      -10
Flag Coverage Δ
daemon 43.24% <4.76%> (-0.02%) ⬇️
jina 89.22% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/helper.py 85.51% <ø> (ø)
jina/hubble/hubio.py 63.54% <100.00%> (+4.01%) ⬆️
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.15% <0.00%> (-1.37%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 94.17% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55eb45f...0cfb590. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 10, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1466, delta to last 2 avg.: +10%
  • 🐢🐢 query QPS at 28, delta to last 2 avg.: -12%
  • 🐢🐢 dam extend QPS at 43227, delta to last 2 avg.: -24%
  • 🐢🐢 avg flow time within 1.8222 seconds, delta to last 2 avg.: +0%
  • 🐢🐢 import jina within 0.3238 seconds, delta to last 2 avg.: -15%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1466 28 43227 1.8222 0.3238
2.0.16 1364 32 58517 1.8146 0.3766
2.0.15 1299 31 56250 1.8163 0.3919

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/L area/testing This issue/PR affects testing and removed size/S labels Aug 10, 2021
hanxiao
hanxiao reviewed Aug 10, 2021
View reviewed changes
@numb3r3 numb3r3 requested a review from hanxiao August 10, 2021 06:29
@hanxiao hanxiao merged commit 845e880 into master Aug 10, 2021
@hanxiao hanxiao deleted the fix-hubble-progressbar branch August 10, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaeddine-13 alaeddine-13 Awaiting requested review from alaeddine-13

@JoanFM JoanFM Awaiting requested review from JoanFM

@tadejsv tadejsv Awaiting requested review from tadejsv

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@numb3r3 @hanxiao
0