8000 feat: supporting jina hub push --tag and --docker-file by mapleeit · Pull Request #3116 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: supporting jina hub push --tag and --docker-file #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 9, 2021
Merged

feat: supporting jina hub push --tag and --docker-file #3116

merged 7 commits into from
Aug 9, 2021

Conversation

mapleeit
Copy link
Contributor
@mapleeit mapleeit commented Aug 6, 2021

No description provided.

@mapleeit mapleeit requested a review from a team as a code owner August 6, 2021 08:05
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing labels Aug 6, 2021
@github-actions
Copy link
github-actions bot commented Aug 6, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1315, delta to last 2 avg.: -2%
  • 🐢🐢 query QPS at 31, delta to last 2 avg.: -9%
  • 🐢🐢 dam extend QPS at 58659, delta to last 2 avg.: -6%
  • 🐢🐢 avg flow time within 1.926 seconds, delta to last 2 avg.: +12%
  • 😶 import jina within 0.3851 seconds, delta to last 2 avg.: +1%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1315 31 58659 1.926 0.3851
2.0.16 1424 38 69901 1.5888 0.3715
2.0.15 1279 30 55410 1.8424 0.3886

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Aug 6, 2021
@codecov
Copy link
codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #3116 (b446e38) into master (01564f9) will decrease coverage by 0.17%.
The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3116      +/-   ##
==========================================
- Coverage   89.42%   89.25%   -0.18%     
==========================================
  Files         142      143       +1     
  Lines        9653     9649       -4     
==========================================
- Hits         8632     8612      -20     
- Misses       1021     1037      +16
Flag Coverage Δ
daemon 43.73% <0.00%> (-0.14%) ⬇️
jina 89.24% <60.86%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/hubio.py 63.12% <57.14%> (-1.17%) ⬇️
jina/parsers/hubble/push.py 94.44% <100.00%> (+0.69%) ⬆️
jina/peapods/peas/__init__.py 86.14% <0.00%> (-4.22%) ⬇️
jina/peapods/pods/compound.py 90.41% <0.00%> (-1.37%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 92.64% <0.00%> (ø)
jina/peapods/runtimes/zmq/zed.py 93.84% <0.00%> (+<0.01%) ⬆️
jina/types/document/__init__.py 96.28% <0.00%> (+0.14%) ⬆️
jina/peapods/zmq/__init__.py 88.88% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01564f9...b446e38. Read the comment docs.

@JoanFM JoanFM changed the title Feat supporting jina hub push --tag and --docker-file feat: supporting jina hub push --tag and --docker-file Aug 6, 2021
tadejsv
tadejsv reviewed Aug 6, 2021
View reviewed changes
alaeddine-13
alaeddine-13 reviewed Aug 6, 2021
View reviewed changes
@mapleeit
Copy link
Contributor Author
mapleeit commented Aug 9, 2021

@tadej-redstone @alaeddine-13 Thanks for your suggestions. I already made some changes. It could be nice if you can review again.

numb3r3
numb3r3 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member
@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit dbe1788 into master Aug 9, 2021
@numb3r3 numb3r3 deleted the feat-hub-tags branch August 9, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadejsv tadejsv tadejsv left review comments

@alaeddine-13 alaeddine-13 alaeddine-13 left review comments

@numb3r3 numb3r3 numb3r3 approved these changes

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@slettner slettner Awaiting requested review from slettner

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mapleeit @tadejsv @alaeddine-13 @numb3r3 @jina-bot
0