8000 docs(README.md): update console output to match by PLNech · Pull Request #3100 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(README.md): update console output to match #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2021
Merged

docs(README.md): update console output to match #3100

merged 1 commit into from
Aug 25, 2021

Conversation

PLNech
Copy link
Contributor
@PLNech PLNech commented Aug 4, 2021 •
edited
Loading

Hello Jina! I'm discovering your great framework, and got confused by the document [3] in the client console output in this part of the README:

README Console output example including a line that was never indexed

In my console running this guide's example, I was rather getting:

[0]0.168526: "@requests(on='/index')"
[1]0.181676: "@requests(on='/search')"
[2]0.218218: "from jina import Document, DocumentArray, Executor, Flow, requests"

It looks like this example output references lines from a previous version of the server code.
Hence, this PR updates the console example's results to match the current README-SERVER code, as the line with query.matches currently in the documented output is no more in the indexed documents.

All the best 👋

@PLNech PLNech requested a review from hanxiao as a code owner August 4, 2021 11:32
@bwanglzu
Copy link
Member
bwanglzu commented Aug 5, 2021

hi @PLNech good observation. thanks for the PR :)

nan-wang
nan-wang requested changes Aug 15, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad commit message, please refer to:

@PLNech
Copy link
Contributor Author
PLNech commented Aug 19, 2021

@nan-wang thanks for the review, repushed as docs(readme): Update console output to match, let me know if this LGTY!

@PLNech PLNech requested a review from nan-wang August 19, 2021 14:59
@PLNech
docs(readme): update console output to match
2136457 
Updates the console example's results to match the current README-SERVER code, as the line with `query.match` currently in the documented output is no more in the indexed documents.
@PLNech PLNech changed the title fix(README.md): Update console output to match docs(README.md): update console output to match Aug 19, 2021
@hanxiao hanxiao merged commit 701729d into jina-ai:master Aug 25, 2021
@davidofell5
Copy link

@PLNech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PLNech @bwanglzu @davidofell5 @nan-wang @hanxiao
0