8000 fix(http): tag update by deepankarm · Pull Request #3108 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(http): tag update #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2021
Merged

fix(http): tag update #3108

merged 1 commit into from
Aug 5, 2021

Conversation

deepankarm
Copy link
Contributor

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner August 5, 2021 07:57
@deepankarm deepankarm requested review from CatStark and tadejsv August 5, 2021 07:57
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Aug 5, 2021
@deepankarm deepankarm linked an issue Aug 5, 2021 that may be closed by this pull request
documents getting merged via REST API indexing #3106
Closed
@codecov
Copy link
codecov bot commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #3108 (5e31110) into master (55df38f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3108      +/-   ##
==========================================
- Coverage   89.31%   89.29%   -0.02%     
==========================================
  Files         142      142              
  Lines        9652     9653       +1     
==========================================
- Hits         8621     8620       -1     
- Misses       1031     1033       +2
Flag Coverage Δ
daemon 43.89% <0.00%> (-0.01%) ⬇️
jina 89.28% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/gateway/http/models.py 100.00% <100.00%> (ø)
jina/helper.py 79.54% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1b8d1...5e31110. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 5, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1515, delta to last 2 avg.: -11%
  • 🐢🐢 query QPS at 35, delta to last 2 avg.: -13%
  • 🐢🐢 dam extend QPS at 62319, delta to last 2 avg.: -21%
  • 🐢🐢 avg flow time within 1.8677 seconds, delta to last 2 avg.: +4%
  • 😶 import jina within 0.3043 seconds, delta to last 2 avg.: +0%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1515 35 62319 1.8677 0.3043
2.0.16 1500 34 66700 1.818 0.3281
2.0.15 1939 46 92638 1.75 0.2759

Backed by latency-tracking. Further commits will update this comment.

cristianmtr
cristianmtr previously approved these changes Aug 5, 2021
View reviewed changes
@deepankarm deepankarm requested a review from cristianmtr August 5, 2021 09:43
@deepankarm deepankarm merged commit 01564f9 into master Aug 5, 2021
@deepankarm deepankarm deleted the fix-tag-updater branch August 5, 2021 11:17
@hanxiao hanxiao mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr cristianmtr approved these changes

@CatStark CatStark Awaiting requested review from CatStark

@tadejsv tadejsv Awaiting requested review from tadejsv

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

documents getting merged via REST API indexing
2 participants
@deepankarm @cristianmtr
0