8000 feat(executor): add uses-requests cli to override requests in Executor by hanxiao · Pull Request #3092 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(executor): add uses-requests cli to override requests in Executor #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2021
Merged

feat(executor): add uses-requests cli to override requests in Executor #3092

merged 2 commits into from
Aug 4, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Aug 3, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner August 3, 2021 15:46
@github-actions
Copy link
github-actions bot commented Aug 3, 2021

This PR closes: #3091

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/jaml component/peapod labels Aug 3, 2021
@hanxiao hanxiao closed this Aug 3, 2021
@hanxiao hanxiao reopened this Aug 3, 2021
@github-actions github-actions bot added size/M area/cli This issue/PR affects the command line interface component/flow and removed size/S labels Aug 3, 2021
@github-actions
Copy link
github-actions bot commented Aug 3, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1423, delta to last 2 avg.: -17%
  • 🐢🐢 query QPS at 35, delta to last 2 avg.: -19%
  • 🐢🐢 dam extend QPS at 71667, delta to last 2 avg.: -7%
  • 🐢🐢 avg flow time within 1.3309 seconds, delta to last 2 avg.: -18%
  • 🐎🐎🐎🐎 import jina within 0.3988 seconds, delta to last 2 avg.: +23%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1423 35 71667 1.3309 0.3988
2.0.16 1757 47 83600 1.4818 0.2947
2.0.15 1712 39 70797 1.7856 0.3527

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Aug 3, 2021 •
edited
Loading

Codecov Report

Merging #3092 (7378157) into master (3ff5fe9) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
- Coverage   89.36%   88.56%   -0.80%     
==========================================
  Files         142      142              
  Lines        9516     9515       -1     
==========================================
- Hits         8504     8427      -77     
- Misses       1012     1088      +76
Flag Coverage Δ
daemon 43.87% <54.54%> (+0.04%) ⬆️
jina 88.55% <100.00%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 88.97% <ø> (ø)
jina/peapods/runtimes/zmq/zed.py 92.73% <ø> (ø)
jina/jaml/__init__.py 95.21% <100.00%> (-0.05%) ⬇️
jina/parsers/peapods/runtimes/zed.py 100.00% <100.00%> (ø)
jina/peapods/runtimes/container/__init__.py 64.92% <0.00%> (-20.15%) ⬇️
jina/peapods/networking.py 91.42% <0.00%> (-8.58%) ⬇️
jina/peapods/peas/helper.py 87.80% <0.00%> (-4.88%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 89.04% <0.00%> (-4.11%) ⬇️
jina/peapods/pods/__init__.py 82.97% <0.00%> (-3.65%) ⬇️
jina/peapods/runtimes/base.py 84.84% <0.00%> (-3.04%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff5fe9...7378157. Read the comment docs.

@hanxiao hanxiao merged commit 990a51d into master Aug 4, 2021
@hanxiao hanxiao deleted the fix-3091 branch August 4, 2021 01:44
davidbp pushed a commit that referenced this pull request Aug 4, 2021
@hanxiao @jina-bot @davidbp
feat(executor): add uses-requests cli to override requests in Executor (
71a5fca 
#3092)

* feat(executor): add uses-requests cli to override requests in Executor

* style: fix overload and cli autocomplete

Co-authored-by: Jina Dev Bot <dev-bot@jina.ai>
@hanxiao hanxiao mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit Awaiting requested review from mapleeit

@alaeddine-13 alaeddine-13 Awaiting requested review from alaeddine-13

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/jaml component/peapod size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0