8000 docs: update cookbooks #138 by alaeddine-13 · Pull Request #3098 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: update cookbooks #138 #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 10, 2021
Merged

docs: update cookbooks #138 #3098

merged 20 commits into from
Aug 10, 2021

Conversation

alaeddine-13
Copy link
Contributor

@github-actions github-actions bot added size/M area/housekeeping This issue/PR is housekeeping labels Aug 4, 2021
@github-actions
Copy link
github-actions bot commented Aug 4, 2021

This PR closes: #138

@codecov
Copy link
codecov bot commented Aug 4, 2021 •
edited
Loading

Codecov Report

Merging #3098 (fe00117) into master (1f03fef) will decrease coverage by 4.96%.
The diff coverage is n/a.

❗ Current head fe00117 differs from pull request most recent head 90d31d7. Consider uploading reports for the commit 90d31d7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   87.96%   82.99%   -4.97%     
==========================================
  Files         143      145       +2     
  Lines        9662     9928     +266     
==========================================
- Hits         8499     8240     -259     
- Misses       1163     1688     +525
Flag Coverage Δ
daemon 43.23% <ø> (+3.88%) ⬆️
jina 82.98% <ø> (-4.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/graph.py 43.71% <ø> (-38.20%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/math/dimensionality_reduction.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/arrays/search_ops.py 23.07% <0.00%> (-76.93%) ⬇️
jina/types/arrays/neural_ops.py 37.89% <0.00%> (-49.07%) ⬇️
jina/types/score/__init__.py 48.64% <0.00%> (-48.65%) ⬇️
jina/types/document/multimodal.py 57.14% <0.00%> (-38.78%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f03fef...90d31d7. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 4, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1304, delta to last 2 avg.: -24%
  • 🐢🐢 query QPS at 25, delta to last 2 avg.: -45%
  • 🐢🐢 dam extend QPS at 46136, delta to last 2 avg.: -45%
  • 🐢🐢 avg flow time within 1.8426 seconds, delta to last 2 avg.: +42%
  • 🐎🐎🐎🐎 import jina within 0.3877 seconds, delta to last 2 avg.: +31%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1304 25 46136 1.8426 0.3877
2.0.16 1698 45 83966 1.1681 0.2973
2.0.15 1776 46 85014 1.4204 0.2935

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added area/core This issue/PR affects the core codebase component/type labels Aug 5, 2021
@alaeddine-13 alaeddine-13 force-pushed the docs-update-cookbooks-138 branch from f8a87fa to 5d31d1c Compare August 6, 2021 08:59
maximilianwerk
maximilianwerk reviewed Aug 6, 2021
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. :) Some minor comments

@alaeddine-13 alaeddine-13 force-pushed the docs-update-cookbooks-138 branch from 88f9a56 to 878f307 Compare August 6, 2021 11:08
@github-actions github-actions bot added size/L and removed size/M labels Aug 9, 2021
@alaeddine-13 alaeddine-13 marked this pull request as ready for review August 9, 2021 06:43
@alaeddine-13 alaeddine-13 requested a review from a team as a code owner August 9, 2021 06:43
@alaeddine-13 alaeddine-13 force-pushed the docs-update-cookbooks-138 branch from 6bf7973 to a6e49b6 Compare August 9, 2021 06:46
@alaeddine-13 alaeddine-13 force-pushed the docs-update-cookbooks-138 branch from 179ecce to d7b73d7 Compare August 9, 2021 08:40
@github-actions github-actions bot added size/XL area/cli This issue/PR affects the command line interface area/testing This issue/PR affects testing size/L and removed size/L size/XL area/testing This issue/PR affects testing area/cli This issue/PR affects the command line interface labels Aug 9, 2021
@alaeddine-13 alaeddine-13 force-pushed the docs-update-cookbooks-138 branch from 6b4688b to c5d7b63 Compare August 9, 2021 08:52
maximilianwerk
maximilianwerk reviewed Aug 9, 2021
View reviewed changes
.github/2.0/cookbooks/Executor.md Outdated
@@ -573,7 +579,7 @@ with Flow().\

---

## Migration in Practice
## Migrating from 1.x to 2.0 in Practice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section be removed completely? @hanxiao

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i'm taking this branch now

cristianmtr
cristianmtr reviewed Aug 9, 2021
View reviewed changes
cristianmtr
cristianmtr reviewed Aug 9, 2021
View reviewed changes
@alaeddine-13 @cristianmtr
chore: apply review suggestions
a3b9f95 
Co-authored-by: cristian <cristianmtr@users.noreply.github.com>
hanxiao
hanxiao requested changes Aug 10, 2021
View reviewed changes
Copy link
Member
@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm taking this branch now for final touch

67ED
@github-actions github-actions bot added size/XL and removed size/L labels Aug 10, 2021
@hanxiao hanxiao merged commit 9e20540 into master Aug 10, 2021
@hanxiao hanxiao deleted the docs-update-cookbooks-138 branch August 10, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk maximilianwerk left review comments

@cristianmtr cristianmtr cristianmtr left review comments

@hanxiao hanxiao hanxiao requested changes

@alanthssss alanthssss Awaiting requested review from alanthssss

@Gikiman Gikiman Awaiting requested review from Gikiman

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping component/type size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alaeddine-13 @hanxiao @maximilianwerk @cristianmtr
0