8000 fix: fix 0 sparse array by JoanFM · Pull Request #3073 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix 0 sparse array #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

fix: fix 0 sparse array #3073

merged 1 commit into from
Aug 2, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Aug 2, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner August 2, 2021 14:13
@JoanFM JoanFM linked an issue Aug 2, 2021 that may be closed by this pull request
document attribute embedding returns None if embedding is zero sparse #3067
Closed
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Aug 2, 2021
@codecov
Copy link
codecov bot commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #3073 (73aa9b7) into master (27d93c2) will increase coverage by 1.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
+ Coverage   86.21%   88.17%   +1.95%     
==========================================
  Files         142      142              
  Lines        9503     9505       +2     
==========================================
+ Hits         8193     8381     +188     
+ Misses       1310     1124     -186
Flag Coverage Δ
daemon 43.74% <0.00%> (-0.01%) ⬇️
jina 87.97% <100.00%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/ndarray/dense/numpy.py 100.00% <100.00%> (ø)
jina/jaml/parsers/flow/v1.py 49.01% <0.00%> (-45.10%) ⬇️
jina/clients/__init__.py 86.20% <0.00%> (-13.80%) ⬇️
jina/flow/base.py 78.24% <0.00%> (-10.78%) ⬇️
jina/peapods/peas/__init__.py 87.29% <0.00%> (-4.98%) ⬇️
jina/clients/base/http.py 88.63% <0.00%> (-4.55%) ⬇️
jina/jaml/helper.py 82.50% <0.00%> (-2.50%) ⬇️
jina/peapods/runtimes/zmq/zed.py 91.02% <0.00%> (-1.71%) ⬇️
jina/types/message/__init__.py 85.78% <0.00%> (-1.48%) ⬇️
jina/peapods/runtimes/gateway/http/app.py 91.78% <0.00%> (-1.37%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d93c2...73aa9b7. Read the comment docs.

@JoanFM JoanFM requested a review from davidbp August 2, 2021 14:20
@github-actions
Copy link
github-actions bot commented Aug 2, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1209, delta to last 2 avg.: -18%
  • 🐢🐢 query QPS at 29, delta to last 2 avg.: -23%
  • 🐢🐢 dam extend QPS at 52646, delta to last 2 avg.: -24%
  • 🐢🐢 avg flow time within 1.9153 seconds, delta to last 2 avg.: +11%
  • 🐎🐎🐎🐎 import jina within 0.4376 seconds, delta to last 2 avg.: +22%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1209 29 52646 1.9153 0.4376
2.0.15 1417 35 66795 1.6412 0.3607
2.0.14 1550 41 73585 1.7975 0.3526

Backed by latency-tracking. Further commits will update this comment.

davidbp
davidbp approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor
@davidbp davidbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit 671a310 into master Aug 2, 2021
@JoanFM JoanFM deleted the empty-sparse branch August 2, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbp davidbp davidbp approved these changes

@deepankarm deepankarm Awaiting requested review from deepankarm

@jakobkruse1 jakobkruse1 Awaiting requested review from jakobkruse1

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document attribute embedding returns None if embedding is zero sparse
2 participants
@JoanFM @davidbp
0