8000 fix(setup): fix missing wheel dependencies in setup.py by hanxiao · Pull Request #3078 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(setup): fix missing wheel dependencies in setup.py #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2021
Merged

fix(setup): fix missing wheel dependencies in setup.py #3078

merged 2 commits into from
Aug 3, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Aug 3, 2021

No description provided.

@github-actions github-actions bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina labels Aug 3, 2021
@hanxiao hanxiao linked an issue Aug 3, 2021 that may be closed by this pull request
[Pip] jina installation throws error until wheel is manually installed - should this be expected? #3071
Closed
@github-actions
Copy link
github-actions bot commented Aug 3, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1374, delta to last 2 avg.: -10%
  • 🐢🐢 query QPS at 33, delta to last 2 avg.: -18%
  • 🐢🐢 dam extend QPS at 61525, delta to last 2 avg.: -16%
  • 🐢🐢 avg flow time within 1.8537 seconds, delta to last 2 avg.: +45%
  • 😶 import jina within 0.3456 seconds, delta to last 2 avg.: -2%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1374 33 61525 1.8537 0.3456
2.0.15 1466 37 72065 1.3111 0.3704
2.0.14 1589 42 74617 1.241 0.3413

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao closed this Aug 3, 2021
@hanxiao hanxiao reopened this Aug 3, 2021
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase component/resource and removed size/S labels Aug 3, 2021
@codecov
Copy link
codecov bot commented Aug 3, 2021 •
edited
Loading

Codecov Report

Merging #3078 (e84e539) into master (5037324) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
- Coverage   89.36%   89.32%   -0.04%     
==========================================
  Files         142      142              
  Lines        9503     9503              
==========================================
- Hits         8492     8489       -3     
- Misses       1011     1014       +3
Flag Coverage Δ
daemon 43.75% <ø> (ø)
jina 89.31% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 95.00% <0.00%> (-2.50%) ⬇️
jina/peapods/peas/__init__.py 92.26% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 046356f...e84e539. Read the comment docs.

@hanxiao hanxiao merged commit 4951b3d into master Aug 3, 2021
@hanxiao hanxiao deleted the fix-dependencies branch August 3, 2021 07:48
@CatStark CatStark mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina component/resource size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pip] jina installation throws error until wheel is manually installed - should this be expected?
2 participants
@hanxiao @jina-bot
0