8000 fix(math): fix minmax normalize to row-wise normalization by hanxiao · Pull Request #3065 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(math): fix minmax normalize to row-wise normalization #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

fix(math): fix minmax normalize to row-wise normalization #3065

merged 1 commit into from
Aug 2, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Aug 2, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner August 2, 2021 05:52
@hanxiao hanxiao requested review from CatStark and JoanFM August 2, 2021 05:52
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/math labels Aug 2, 2021
@codecov
Copy link
codecov bot commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #3065 (6ab5991) into master (bac641d) will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
+ Coverage   87.58%   88.02%   +0.44%     
==========================================
  Files         142      142              
  Lines        9503     9503              
==========================================
+ Hits         8323     8365      +42     
+ Misses       1180     1138      -42
Flag Coverage Δ
daemon 43.75% <0.00%> (ø)
jina 87.82% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/math/helper.py 90.47% <100.00%> (ø)
jina/jaml/parsers/flow/v1.py 49.01% <0.00%> (-45.10%) ⬇️
jina/clients/__init__.py 86.20% <0.00%> (-13.80%) ⬇️
jina/flow/base.py 78.24% <0.00%> (-10.78%) ⬇️
jina/jaml/parsers/__init__.py 92.68% <0.00%> (-7.32%) ⬇️
jina/peapods/peas/__init__.py 87.29% <0.00%> (-7.19%) ⬇️
jina/clients/base/http.py 88.63% <0.00%> (-4.55%) ⬇️
jina/peapods/runtimes/zmq/zed.py 91.02% <0.00%> (-1.71%) ⬇️
jina/clients/base/__init__.py 90.90% <0.00%> (-1.52%) ⬇️
jina/types/message/__init__.py 85.78% <0.00%> (-1.48%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac641d...6ab5991. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Aug 2, 2021

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1313, delta to last 2 avg.: +6%
  • 😶 query QPS at 31, delta to last 2 avg.: +5%
  • 😶 dam extend QPS at 57994, delta to last 2 avg.: +7%
  • 😶 avg flow time within 1.8494 seconds, delta to last 2 avg.: +12%
  • 😶 import jina within 0.3773 seconds, delta to last 2 avg.: -4%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1313 31 57994 1.8494 0.3773
2.0.15 1282 28 55816 1.3611 0.3834
2.0.14 1194 30 52329 1.9242 0.4042

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 27d93c2 into master Aug 2, 2021
@hanxiao hanxiao deleted the fix-minmax-normalize branch August 2, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark Awaiting requested review from CatStark

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/math size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0