8000 fix(http): fix pydantic models by hanxiao · Pull Request #3046 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(http): fix pydantic models #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2021
Merged

fix(http): fix pydantic models #3046

merged 1 commit into from
Jul 30, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jul 30, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner July 30, 2021 03:27
@hanxiao hanxiao requested review from mapleeit and winstonww July 30, 2021 03:27
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Jul 30, 2021
@codecov
Copy link
codecov bot commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #3046 (55a54e8) into master (f40d796) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3046      +/-   ##
==========================================
+ Coverage   89.35%   89.39%   +0.04%     
==========================================
  Files         141      141              
  Lines        9489     9489              
==========================================
+ Hits         8479     8483       +4     
+ Misses       1010     1006       -4
Flag Coverage Δ
daemon 43.99% <ø> (-0.03%) ⬇️
jina 89.38% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/gateway/http/models.py 100.00% <ø> (ø)
jina/peapods/runtimes/gateway/prefetch.py 94.52% <0.00%> (+1.36%) ⬆️
jina/clients/base/grpc.py 70.21% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4694b76...55a54e8. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1714, delta to last 2 avg.: +1%
  • 🐎🐎🐎🐎 query QPS at 25, delta to last 2 avg.: +22%
  • 🐎🐎🐎🐎 dam extend QPS at 67707, delta to last 2 avg.: +6%
  • 🐎🐎🐎🐎 avg flow time within 1.3102 seconds, delta to last 2 avg.: -12%
  • 😶 import jina within 0.3465 seconds, delta to last 2 avg.: +5%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1714 25 67707 1.3102 0.3465
2.0.13 1690 18 60261 1.7989 0.3075
2.0.12 1678 21 66964 1.2102 0.3489

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit c687fac into master Jul 30, 2021
@hanxiao hanxiao deleted the fix-request-pydantic-model branch July 30, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit Awaiting requested review from mapleeit

@winstonww winstonww Awaiting requested review from winstonww

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0