8000 feat(hub): add new command to jina hub CLI by hanxiao · Pull Request #3031 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(hub): add new command to jina hub CLI #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2021
Merged

feat(hub): add new command to jina hub CLI #3031

merged 5 commits into from
Jul 28, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jul 28, 2021 •
edited
Loading

image

@hanxiao hanxiao requested a review from a team as a code owner July 28, 2021 12:46
@hanxiao hanxiao requested review from deepankarm and slettner July 28, 2021 12:46
@jina-bot jina-bot added size/M area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase component/resource labels Jul 28, 2021
@github-actions
Copy link
github-actions bot commented Jul 28, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1843, delta to last 2 avg.: +7%
  • 😶 query QPS at 20, delta to last 2 avg.: -4%
  • 😶 dam extend QPS at 69026, delta to last 2 avg.: +4%
  • 😶 avg flow time within 1.7626 seconds, delta to last 2 avg.: +15%
  • 🐢🐢 import jina within 0.2758 seconds, delta to last 2 avg.: -17%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1843 20 69026 1.7626 0.2758
2.0.11 1471 16 56044 1.848 0.3719
2.0.10 1965 24 75851 1.2044 0.2945

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jul 28, 2021
@codecov
Copy link
codecov bot commented Jul 28, 2021 •
edited
Loading

Codecov Report

Merging #3031 (8f7cc2d) into master (5f150f1) will decrease coverage by 1.49%.
The diff coverage is 5.71%.

❗ Current head 8f7cc2d differs from pull request most recent head 49fc306. Consider uploading reports for the commit 49fc306 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3031      +/-   ##
==========================================
- Coverage   82.38%   80.89%   -1.50%     
==========================================
  Files         141      141              
  Lines        9414     9484      +70     
==========================================
- Hits         7756     7672      -84     
- Misses       1658     1812     +154
Flag Coverage Δ
daemon 44.03% <4.28%> (-0.28%) ⬇️
jina 80.69% <5.71%> (-1.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/hubio.py 64.28% <4.34%> (-21.00%) ⬇️
jina/parsers/hubble/__init__.py 96.15% <100.00%> (+0.15%) ⬆️
jina/jaml/parsers/flow/v1.py 49.01% <0.00%> (-45.10%) ⬇️
jina/clients/__init__.py 79.31% <0.00%> (-20.69%) ⬇️
jina/clients/mixin.py 84.84% <0.00%> (-15.16%) ⬇️
jina/importer.py 72.64% <0.00%> (-12.27%) ⬇️
jina/flow/base.py 78.24% <0.00%> (-8.79%) ⬇️
jina/jaml/parsers/__init__.py 92.68% <0.00%> (-7.32%) ⬇️
jina/clients/base/__init__.py 86.36% <0.00%> (-6.07%) ⬇️
jina/peapods/networking.py 85.71% <0.00%> (-5.72%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f150f1...49fc306. Read the comment docs.

@hanxiao hanxiao merged commit 28a3818 into master Jul 28, 2021
@hanxiao hanxiao deleted the feat-jina-hub-new branch July 28, 2021 13:11
alaeddine-13 pushed a commit that referenced this pull request Jul 30, 2021
@hanxiao @jina-bot @alaeddine-13
feat(hub): add new command to jina hub CLI (#3031)
ae6dba8 
Co-authored-by: Jina Dev Bot <dev-bot@jina.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepankarm deepankarm Awaiting requested review from deepankarm

@slettner slettner Awaiting requested review from slettner

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping component/resource size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0