8000 ci: cancel prev runs for tests by deepankarm · Pull Request #3007 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: cancel prev runs for tests #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2021
Merged

ci: cancel prev runs for tests #3007

merged 2 commits into from
Jul 26, 2021

Conversation

deepankarm
Copy link
Contributor
@deepankarm deepankarm commented Jul 25, 2021 •
edited
Loading

Added steps (styfle/cancel-workflow-action@0.9.0) to cancel runs from previous commits in a PR for docker-image-test, hub-test, core-test, latency-tracking

@deepankarm deepankarm requested a review from hanxiao as a code owner July 25, 2021 12:57
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jul 25, 2021
@codecov
Copy link
codecov bot commented Jul 25, 2021 •
edited
Loading

Codecov Report

Merging #3007 (ba16d07) into master (46ddd13) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
+ Coverage   89.95%   90.00%   +0.04%     
==========================================
  Files         140      140              
  Lines        9510     9510              
==========================================
+ Hits         8555     8559       +4     
+ Misses        955      951       -4
Flag Coverage Δ
daemon 44.05% <ø> (+0.02%) ⬆️
jina 89.98% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/peas/__init__.py 92.81% <0.00%> (+0.55%) ⬆️
jina/peapods/runtimes/jinad/client.py 91.71% <0.00%> (+1.18%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 97.05% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a79d6...ba16d07. Read the comment docs.

@deepankarm
Copy link
Contributor Author

Verified cancellation of latency-tracking.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 2003, delta to last 2 avg.: +0%
  • 😶 query QPS at 25, delta to last 2 avg.: -5%
  • 😶 dam extend QPS at 76550, delta to last 2 avg.: +0%
  • 😶 avg flow time within 1.4756 seconds, delta to last 2 avg.: +0%
  • 😶 import jina within 0.3041 seconds, delta to last 2 avg.: -1%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 2003 25 76550 1.4756 0.3041
2.0.10 1970 25 76973 1.4618 0.3149
2.0.9 2070 27 75730 1.4878 0.3024

Backed by latency-tracking. Further commits will update this comment.

nan-wang
nan-wang approved these changes Jul 25, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 How can we verify that this actually works?

@deepankarm
Copy link
Contributor Author

LGTM👍 How can we verify that this actually works?

Verified cancellation of latency-tracking.

@hanxiao hanxiao merged commit 8802287 into master Jul 26, 2021
@hanxiao hanxiao deleted the ci-cancel-previous-runs branch July 26, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepankarm @nan-wang @hanxiao @jina-bot
0