test: add test rolling update docker #2999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2999 +/- ##
==========================================
+ Coverage 89.94% 89.97% +0.02%
==========================================
Files 139 139
Lines 9479 9483 +4
==========================================
+ Hits 8526 8532 +6
+ Misses 953 951 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
cristianmtr
suggested changes
Jul 23, 2021
| def update_rolling(flow, pod_name): | ||
| with reraise: | ||
| flow.rolling_update(pod_name) | ||
|
|
||
| error_mock = mocker.Mock() | ||
| with Flow().add( | ||
| uses=uses, |
There was a problem hiding this comment.
Does this test actually fail without your changes?
The assert down
error_mock.assert_not_called()
seems weak. Can u check?
There was a problem hiding this comment.
this test hangs without these changes
994df97 to
a3bf7c8
Compare
cristianmtr
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.