8000 refactor(cli): rename override_metas/with to uses_metas/with by hanxiao · Pull Request #2964 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(cli): rename override_metas/with to uses_metas/with #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2021
Merged

refactor(cli): rename override_metas/with to uses_metas/with #2964

merged 2 commits into from
Jul 16, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jul 16, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner July 16, 2021 14:35
@hanxiao hanxiao requested review from nan-wang and BastinJafari July 16, 2021 14:35
@jina-bot jina-bot added size/L area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/peapod labels Jul 16, 2021
@codecov
Copy link
codecov bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #2964 (518838c) into master (06d2f2e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
+ Coverage   90.03%   90.04%   +0.01%     
==========================================
  Files         138      138              
  Lines        9513     9513              
==========================================
+ Hits         8565     8566       +1     
+ Misses        948      947       -1
Flag Coverage Δ
daemon 43.72% <ø> (+0.02%) ⬆️
jina 90.03% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 89.04% <ø> (ø)
jina/parsers/flow.py 100.00% <ø> (ø)
jina/parsers/peapods/pea.py 100.00% <ø> (ø)
jina/parsers/peapods/runtimes/zed.py 100.00% <ø> (ø)
jina/peapods/runtimes/zmq/zed.py 92.73% <ø> (ø)
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py 93.15% <0.00%> (-1.37%) ⬇️
jina/helper.py 80.79% <0.00%> (+0.37%) ⬆️
jina/peapods/runtimes/jinad/client.py 91.71% <0.00%> (+1.18%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 97.05% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d2f2e...518838c. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jul 16, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1686, delta to last 2 avg.: +0%
  • 😶 query QPS at 21, delta to last 2 avg.: -3%
  • 😶 dam extend QPS at 63965, delta to last 2 avg.: -2%
  • 😶 avg flow time within 1.3342 seconds, delta to last 2 avg.: +2%
  • 😶 import jina within 0.3462 seconds, delta to last 2 avg.: -4%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1686 21 63965 1.3342 0.3462
2.0.7 1690 21 65791 1.2984 0.3815
2.0.6 1674 21 65737 1.303 0.3462

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/cicd This issue/PR affects the cicd pipeline label Jul 16, 2021
@hanxiao hanxiao merged commit 3e1ad70 into master Jul 16, 2021
@hanxiao hanxiao deleted the refactor-override-with branch July 16, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang Awaiting requested review from nan-wang

@BastinJafari BastinJafari Awaiting requested review from BastinJafari

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/peapod size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0