8000 test: show external pod started with exec by JoanFM · Pull Request #2952 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: show external pod started with exec #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2021
Merged

test: show external pod started with exec #2952

merged 2 commits into from
Jul 15, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jul 15, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner July 15, 2021 06:48
@jina-bot jina-bot added size/M area/testing This issue/PR affects testing labels Jul 15, 2021
@codecov
Copy link
codecov bot commented Jul 15, 2021 •
edited
Loading

Codecov Report

Merging #2952 (f98c8ac) into master (0094bbf) will increase coverage by 6.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2952      +/-   ##
==========================================
+ Coverage   82.21%   88.89%   +6.67%     
==========================================
  Files         106      138      +32     
  Lines        7064     9607    +2543     
==========================================
+ Hits         5808     8540    +2732     
+ Misses       1256     1067     -189
Flag Coverage Δ
daemon 43.18% <ø> (?)
jina 88.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.64% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 100.00% <ø> (ø)
jina/clients/base/__init__.py 92.42% <ø> (ø)
jina/clients/base/grpc.py 63.82% <ø> (ø)
jina/clients/base/http.py 93.18% <ø> (ø)
jina/clients/base/websocket.py 86.36% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/http.py 100.00% <ø> (ø)
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f74e6...f98c8ac. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jul 15, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1996, delta to last 1 avg.: -1%
  • 😶 query QPS at 25, delta to last 1 avg.: -2%
  • 😶 dam extend QPS at 78341, delta to last 1 avg.: -1%
  • 😶 avg flow time within 1.4505 seconds, delta to last 1 avg.: +4%
  • 😶 import jina within 0.296 seconds, delta to last 1 avg.: -1%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1996 25 78341 1.4505 0.296
2.0.7 2031 25 79198 1.3858 0.3002

Backed by latency-tracking. Further commits will update this comment.

bwanglzu
bwanglzu approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nan-wang
nan-wang approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit de8e01e into master Jul 15, 2021
@nan-wang nan-wang deleted the test-external-executor-local branch July 15, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@bwanglzu bwanglzu bwanglzu approved these changes

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanFM @nan-wang @bwanglzu @jina-bot
0