8000 fix(hubble): logging error message refering to jinahub uri by numb3r3 · Pull Request #2945 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(hubble): logging error message refering to jinahub uri #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix(hubble): logging error message refering to jinahub uri #2945

merged 1 commit into from
Jul 15, 2021

Conversation

numb3r3
Copy link
Member
@numb3r3 numb3r3 commented Jul 14, 2021

No description provided.

@numb3r3 numb3r3 requested a review from winstonww July 14, 2021 06:40
numb3r3 requested a review from a team as a code owner July 14, 2021 06:40
@numb3r3 numb3r3 requested a review from mapleeit July 14, 2021 06:40
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase labels Jul 14, 2021
@numb3r3 numb3r3 linked an issue Jul 14, 2021 that may be closed by this pull request
return more info for 404 error from fetch_meta func #2927
Closed
@codecov
Copy link
codecov bot commented Jul 14, 2021 •
edited
Loading

Codecov Report

Merging #2945 (6b2c086) into master (0094bbf) will increase coverage by 4.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2945      +/-   ##
==========================================
+ Coverage   82.21%   87.09%   +4.87%     
==========================================
  Files         106      138      +32     
  Lines        7064     9569    +2505     
==========================================
+ Hits         5808     8334    +2526     
+ Misses       1256     1235      -21
Flag Coverage Δ
daemon 43.26% <ø> (?)
jina 87.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.64% <ø> (ø)
jina/checker.py 86.20% <ø> (ø)
jina/clients/__init__.py 100.00% <ø> (ø)
jina/clients/base/__init__.py 92.42% <ø> (ø)
jina/clients/base/grpc.py 63.82% <ø> (ø)
jina/clients/base/http.py 93.18% <ø> (ø)
jina/clients/base/websocket.py 86.36% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 50.00% <ø> (ø)
jina/clients/http.py 100.00% <ø> (ø)
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd93a9...6b2c086. Read the comment docs.

nan-wang
nan-wang approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit bab6323 into master Jul 15, 2021
@nan-wang nan-wang deleted the fix-hub-fetch-logging branch July 15, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@winstonww winstonww Awaiting requested review from winstonww

@mapleeit mapleeit Awaiting requested review from mapleeit

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return more info for 404 error from fetch_meta func
3 participants
@numb3r3 @nan-wang @jina-bot
0