8000 tests: add tests for termination by JoanFM · Pull Request #2924 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tests: add tests for termination #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2021
Merged

tests: add tests for termination #2924

merged 3 commits into from
Jul 13, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jul 12, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner July 12, 2021 09:57
@JoanFM JoanFM requested review from winstonww and numb3r3 July 12, 2021 09:57
@jina-bot jina-bot added size/M area/testing This issue/PR affects testing labels Jul 12, 2021
@JoanFM JoanFM force-pushed the test-hanging-pod-flush branch from 552ad2c to 152b409 Compare July 12, 2021 10:38
@codecov
Copy link
codecov bot commented Jul 12, 2021 •
edited
Loading

Codecov Report

Merging #2924 (1aecb85) into master (abb2776) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
+ Coverage   88.83%   88.98%   +0.14%     
==========================================
  Files         138      138              
  Lines        9567     9567              
==========================================
+ Hits         8499     8513      +14     
+ Misses       1068     1054      -14
Flag Coverage Δ
daemon 43.25% <ø> (+0.02%) ⬆️
jina 88.97% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/compound.py 91.54% <0.00%> (+1.40%) ⬆️
jina/clients/base/__init__.py 92.42% <0.00%> (+1.51%) ⬆️
jina/peapods/peas/__init__.py 98.23% <0.00%> (+2.35%) ⬆️
jina/peapods/runtimes/jinad/client.py 90.53% <0.00%> (+4.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb2776...1aecb85. Read the comment docs.

numb3r3
numb3r3 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member
@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit d81cd36 into master Jul 13, 2021
@JoanFM JoanFM deleted the test-hanging-pod-flush branch July 13, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numb3r3 numb3r3 numb3r3 approved these changes

@winstonww winstonww Awaiting requested review from winstonww

Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @numb3r3 @jina-bot
0