8000 feat: enabled latency-tracking CI job on push & PR by maateen · Pull Request #2874 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: enabled latency-tracking CI job on push & PR #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2021
Merged

feat: enabled latency-tracking CI job on push & PR #2874

merged 5 commits into from
Jul 8, 2021

Conversation

maateen
Copy link
Contributor
@maateen maateen commented Jul 7, 2021

Changes:

  • enabled latency-tracking CI job on push & PR

@maateen maateen requested a review from hanxiao as a code owner July 7, 2021 09:50
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jul 7, 2021
@github-actions
Copy link
github-actions bot commented Jul 7, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1379, delta to last 1 avg.: +1%
  • 😶 query QPS at 25, delta to last 1 avg.: -2%
  • 🐢🐢 import jina within 0.2486s, delta to last 1 avg.: -7%

Breakdown

Version Index QPS Query QPS Import Time (s)
current 1379 25 0.2486
2.0.3 1357 25 0.2684

Backed by latency-tracking. Further commits will update this comment.

Maksudur Rahman Maateen added 3 commits July 7, 2021 16:37
feat: enabled latency-tracking CI job on push & PR
76faa4e 
Signed-off-by: Maksudur Rahman Maateen <maateen@outlook.com>
fix: fixed latency-tracking CI for PR only
6f6eed5 
Signed-off-by: Maksudur Rahman Maateen <maateen@jina.ai>
fix: fixed latency-tracking CI for PR only
80470c8 
Signed-off-by: Maksudur Rahman Maateen <maateen@jina.ai>
@maateen maateen force-pushed the feat-enable-latency-tracking branch from 31e5e90 to 80470c8 Compare July 7, 2021 10:38
@codecov
Copy link
codecov bot commented Jul 7, 2021 •
edited
Loading

Codecov Report

Merging #2874 (45a53c8) into master (7cbf37e) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2874      +/-   ##
==========================================
+ Coverage   87.89%   88.17%   +0.27%     
==========================================
  Files         138      138              
  Lines        9402     9402              
==========================================
+ Hits         8264     8290      +26     
+ Misses       1138     1112      -26
Flag Coverage Δ
daemon 43.51% <ø> (+0.02%) ⬆️
jina 88.11% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 89.04% <0.00%> (+0.19%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.33% <0.00%> (+0.88%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 97.05% <0.00%> (+1.47%) ⬆️
jina/peapods/peas/__init__.py 98.11% <0.00%> (+2.51%) ⬆️
jina/peapods/runtimes/jinad/client.py 87.57% <0.00%> (+3.55%) ⬆️
jina/peapods/pods/compound.py 91.11% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbf37e...45a53c8. Read the comment docs.

deepankarm
deepankarm suggested changes Jul 7, 2021
View reviewed changes
Maksudur Rahman Maateen added 2 commits July 7, 2021 17:57
@hanxiao hanxiao merged commit 2fd414b into master Jul 8, 2021
@hanxiao hanxiao deleted the feat-enable-latency-tracking branch July 8, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepankarm deepankarm deepankarm approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maateen @deepankarm @hanxiao @jina-bot
0