8000 feat(hubble): add filelock while installing executor from hubble by numb3r3 · Pull Request #2866 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(hubble): add filelock while installing executor from hubble #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2021
Merged

feat(hubble): add filelock while installing executor from hubble #2866

merged 2 commits into from
Jul 12, 2021

Conversation

numb3r3
Copy link
Member
@numb3r3 numb3r3 commented Jul 7, 2021

add a file lock to make the pulling thread-safe

@numb3r3 numb3r3 requested a review from hanxiao July 7, 2021 02:55
@numb3r3 numb3r3 requested a review from a team as a code owner July 7, 2021 02:55
@numb3r3 numb3r3 requested a review from florian-hoenicke July 7, 2021 02:55
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/resource labels Jul 7, 2021
@codecov
Copy link
codecov bot commented Jul 7, 2021 •
edited
Loading

Codecov Report

Merging #2866 (e31487d) into master (0094bbf) will increase coverage by 6.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
+ Coverage   82.21%   88.77%   +6.55%     
==========================================
  Files         106      138      +32     
  Lines        7064     9545    +2481     
==========================================
+ Hits         5808     8474    +2666     
+ Misses       1256     1071     -185
Flag Coverage Δ
daemon 43.33% <ø> (?)
jina 88.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.64% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 100.00% <ø> (ø)
jina/clients/base/__init__.py 90.90% <ø> (ø)
jina/clients/base/grpc.py 63.82% <ø> (ø)
jina/clients/base/http.py 93.18% <ø> (ø)
jina/clients/base/websocket.py 86.36% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/http.py 100.00% <ø> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320f14a...e31487d. Read the comment docs.

@numb3r3 numb3r3 requested review from winstonww and removed request for florian-hoenicke July 7, 2021 03:15
@numb3r3 numb3r3 force-pushed the fix-concurrent-hub-pull branch from 563fa8f to 95bdfab Compare July 8, 2021 05:53
JoanFM
JoanFM previously approved these changes Jul 8, 2021
View reviewed changes
@numb3r3 numb3r3 force-pushed the fix-concurrent-hub-pull branch from 94175dc to b5f40d5 Compare July 9, 2021 08:49
@github-actions
Copy link
github-actions bot commented Jul 9, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1499, delta to last 1 avg.: +0%
  • 😶 query QPS at 27, delta to last 1 avg.: -1%
  • 😶 import jina within 0.23s, delta to last 1 avg.: +0%

Breakdown

Version Index QPS Query QPS Import Time (s)
current 1499 27 0.23
2.0.4 1507 27 0.2281

Backed by latency-tracking. Further commits will update this comment.

@numb3r3 numb3r3 force-pushed the fix-concurrent-hub-pull branch from 5f29e59 to ff38bb2 Compare July 9, 2021 10:38
@numb3r3 numb3r3 requested a review from JoanFM July 9, 2021 11:43
@numb3r3 numb3r3 force-pushed the fix-concurrent-hub-pull branch from ce21538 to 60dc117 Compare July 12, 2021 02:11
nan-wang
nan-wang approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 6c5a64c into master Jul 12, 2021
@nan-wang nan-wang deleted the fix-concurrent-hub-pull branch July 12, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

@winstonww winstonww Awaiting requested review from winstonww

@JoanFM 5BCB JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@numb3r3 @nan-wang @JoanFM @jina-bot
0