10000 fix: removed edge label from flow plot by maximilianwerk · Pull Request #2851 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: removed edge label from flow plot #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Conversation

maximilianwerk
Copy link
Member

The edge label is not needed anymore, since it will always be ROUTER-ROUTER with dynamic routing. Makes much nicer and leaner plots.

@maximilianwerk maximilianwerk requested a review from a team as a code owner July 5, 2021 11:35
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/flow labels Jul 5, 2021
@codecov
Copy link
codecov bot commented Jul 5, 2021

Codecov Report

Merging #2851 (194eeb6) into master (b195b13) will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
+ Coverage   88.18%   88.94%   +0.76%     
==========================================
  Files         138      138              
  Lines        9376     9374       -2     
==========================================
+ Hits         8268     8338      +70     
+ Misses       1108     1036      -72     
Flag Coverage Δ
daemon 47.37% <ø> (+3.60%) ⬆️
jina 88.32% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 89.04% <ø> (+0.15%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.33% <0.00%> (+0.88%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 92.30% <0.00%> (+2.56%) ⬆️
jina/peapods/runtimes/jinad/client.py 87.57% <0.00%> (+10.65%) ⬆️
jina/peapods/pods/compound.py 94.07% <0.00%> (+11.85%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 97.05% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b195b13...194eeb6. Read the comment docs.

@hanxiao hanxiao merged commit c87edd8 into master Jul 5, 2021
@hanxiao hanxiao deleted the fix-remove-edge-label branch July 5, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/flow size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0