fix: container runtime on mac #2821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2821 +/- ##
==========================================
+ Coverage 88.48% 89.05% +0.56%
==========================================
Files 138 138
Lines 9351 9352 +1
==========================================
+ Hits 8274 8328 +54
+ Misses 1077 1024 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoanFM
reviewed
Jul 1, 2021
jina/peapods/networking.py
Outdated
| """Checks is current process is running inside docker.""" | ||
| import subprocess | ||
|
|
||
| result = subprocess.run(['cat', '/proc/self/cgroup'], capture_output=True) |
There was a problem hiding this comment.
not so sure cat is present in every image
2308597 to
22c5be5
Compare
57b1c60 to
181f015
Compare
940cf0e to
323a146
Compare
deepankarm
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable container runtime on Mac again.