8000 refactor: close from start error by JoanFM · Pull Request #2825 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: close from start error #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2021
Merged

refactor: close from start error #2825

merged 1 commit into from
Jul 2, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jul 1, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner July 1, 2021 11:01
@JoanFM JoanFM requested review from mapleeit and alanthssss July 1, 2021 11:01
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/daemon area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/flow component/peapod labels Jul 1, 2021
@codecov
Copy link
codecov bot commented Jul 1, 2021 •
edited
Loading

Codecov Report

Merging #2825 (a6f8ee4) into master (e7b7c83) will increase coverage by 2.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2825      +/-   ##
==========================================
+ Coverage   86.92%   89.05%   +2.13%     
==========================================
  Files         138      138              
  Lines        9351     9347       -4     
==========================================
+ Hits         8128     8324     +196     
+ Misses       1223     1023     -200
Flag Coverage Δ
daemon 47.25% <93.33%> (+<0.01%) ⬆️
jina 88.46% <100.00%> (+2.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 89.08% <ø> (+0.02%) ⬆️
jina/helper.py 81.83% <100.00%> (+16.95%) ⬆️
jina/peapods/pods/__init__.py 86.50% <100.00%> (+0.74%) ⬆️
jina/logging/logger.py 94.17% <0.00%> (+0.97%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.33% <0.00%> (+1.77%) ⬆️
jina/jaml/helper.py 85.00% <0.00%> (+2.50%) ⬆️
jina/peapods/peas/__init__.py 96.15% <0.00%> (+2.56%) ⬆️
jina/jaml/__init__.py 95.09% <0.00%> (+3.92%) ⬆️
jina/enums.py 95.40% <0.00%> (+4.59%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b7c83...a6f8ee4. Read the comment docs.

@JoanFM JoanFM requested review from deepankarm and jacobowitz July 1, 2021 11:35
jacobowitz
jacobowitz approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor
@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely cleaner for the pod 👍

@hanxiao hanxiao merged commit f769a5a into master Jul 2, 2021
@hanxiao hanxiao deleted the close-mini-jinad-object branch July 2, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

@mapleeit mapleeit Awaiting requested review from mapleeit

@alanthssss alanthssss Awaiting requested review from alanthssss

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/flow component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanFM @jacobowitz @hanxiao @jina-bot
0