fix(core): prevent peas from hanging on close #2824
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2824 +/- ##
==========================================
+ Coverage 80.96% 88.74% +7.78%
==========================================
Files 138 138
Lines 9352 9351 -1
==========================================
+ Hits 7572 8299 +727
+ Misses 1780 1052 -728
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
hangs again :( https://github.com/jina-ai/jina/pull/2824/checks?check_run_id=2960786051 Will add the sleep, but try again reproducing locally as well |
actually we may use an old docker image here due to 7978a39 I will rebase the other pr and check what happens |
passing: https://github.com/jina-ai/jina/pull/2799/checks?check_run_id=2960905711 |
|
this should be merged, despite the failing tests:
|
We noticed that this test was failing a lot (but randomly) in ci
I was running this test locally a lot and saw it less often, but it happened as well occasionally. The reason for the failure is that the flow closing hangs, which does so because the Pea closing hangs.
After discussion with @JoanFM we decided to remove the alive check the process as it seems to be unnecessary and was just added recently and may be the reason for the issue.
Another possible workaround was a
time.sleep()after terminating a Pea, but we would rather try to avoid this.I was running this changed version locally hundreds of time and did not encounter the issue anymore.