8000 feat(cli): call version check in another thread by hanxiao · Pull Request #2792 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cli): call version check in another thread #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2021
Merged

feat(cli): call version check in another thread #2792

merged 1 commit into from
Jun 29, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 29, 2021 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito

@hanxiao hanxiao requested a review from a team as a code owner June 29, 2021 07:03
@jina-bot jina-bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Jun 29, 2021
maximilianwerk
maximilianwerk approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No more manual python cli/autocomplete.py runs. 👍

@codecov
Copy link
codecov bot commented Jun 29, 2021 •
edited
Loading

Codecov Report

Merging #2792 (73d7e66) into master (5b8c3ca) will decrease coverage by 3.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   89.41%   86.31%   -3.11%     
==========================================
  Files         137      137              
  Lines        9128     9128              
==========================================
- Hits         8162     7879     -283     
- Misses        966     1249     +283
Flag Coverage Δ
daemon 47.68% <0.00%> (+1.08%) ⬆️
jina 85.39% <100.00%> (-3.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/container/__init__.py 83.67% <100.00%> (ø)
jina/clients/helper.py 47.61% <0.00%> (-52.39%) ⬇️
jina/jaml/parsers/flow/v1.py 49.01% <0.00%> (-45.10%) ⬇️
jina/importer.py 59.25% <0.00%> (-28.40%) ⬇️
jina/clients/__init__.py 79.31% <0.00%> (-20.69%) ⬇️
jina/helper.py 64.88% <0.00%> (-16.67%) ⬇️
jina/types/ndarray/dense/numpy.py 84.61% <0.00%> (-15.39%) ⬇️
jina/clients/mixin.py 84.84% <0.00%> (-15.16%) ⬇️
jina/flow/base.py 78.41% <0.00%> (-10.50%) ⬇️
jina/types/request/__init__.py 88.79% <0.00%> (-10.35%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8c3ca...73d7e66. Read the comment docs.

@hanxiao hanxiao merged commit 13176df into master Jun 29, 2021
@hanxiao hanxiao deleted the feat-ver-check branch June 29, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk maximilianwerk approved these changes

@Kelton8Z Kelton8Z Awaiting requested review from Kelton8Z

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanxiao @maximilianwerk @jina-bot
0