10000 feat(hubble): ignore uuid and secret while push again by numb3r3 · Pull Request #2790 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(hubble): ignore uuid and secret while push again #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 7, 2021
Merged

feat(hubble): ignore uuid and secret while push again #2790

merged 7 commits into from
Jul 7, 2021

Conversation

numb3r3
Copy link
Member
@numb3r3 numb3r3 commented Jun 29, 2021 •
edited by sync-by-unito bot
Loading

Now, everytime the user want to update the executor, the --force and --secret options is required:

$ jina hub push <executor_folder> --force <UUID8> --secret <SECRET>

I don't think it is a good UX experience. I think, the UUID8 and SECRET info can be tracked in a local file, so that the user can directly update executor in hubble without typing UUID repeatly.

┆Issue is synchronized with this Asana task by Unito

@numb3r3 numb3r3 requested review from hanxiao and nan-wang June 29, 2021 04:08
@numb3r3 numb3r3 requested a review from a team as a code owner June 29, 2021 04:08
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase labels Jun 29, 2021
@codecov
Copy link
codecov bot commented Jun 29, 2021 •
edited
Loading

Codecov Report

Merging #2790 (5618d56) into master (7cbf37e) will increase coverage by 0.11%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2790      +/-   ##
==========================================
+ Coverage   87.89%   88.00%   +0.11%     
==========================================
  Files         138      138              
  Lines        9402     9457      +55     
==========================================
+ Hits         8264     8323      +59     
+ Misses       1138     1134       -4
Flag Coverage Δ
daemon 43.31% <9.52%> (-0.18%) ⬇️
jina 87.95% <80.95%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/hubio.py 56.64% <53.84%> (-0.24%) ⬇️
jina/hubble/hubapi.py 80.55% <87.23%> (+5.14%) ⬆️
jina/hubble/helper.py 66.66% <100.00%> (+0.55%) ⬆️
jina/flow/base.py 89.04% <0.00%> (+0.19%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.33% <0.00%> (+0.88%) ⬆️
jina/peapods/pods/compound.py 89.62% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbf37e...5618d56. Read the comment docs.

hanxiao
hanxiao requested changes Jun 29, 2021
View reviewed changes
Copy link
Member
@hanxiao hanxiao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • this does not considered multiple uuid will have different secret
  • secrets are stored in plain text, not secure.
  • missing test
  • this PR should be targeted at refactor-hub-cli

@numb3r3
Copy link
Member Author
numb3r3 commented Jun 29, 2021

this does not considered multiple uuid will have different secret

@hanxiao I don't understand this problem? Now, each folder only contains one executor, and so only one uuid should be considered.

@jina-bot jina-bot added the area/setup This issue/PR affects setting up Jina label Jun 29, 2021
@numb3r3 numb3r3 force-pushed the refactor-push-again branch from 5a1b671 to 2e2ec0e Compare June 29, 2021 06:51
@numb3r3 numb3r3 requested a review from hanxiao June 29, 2021 06:51
@numb3r3 numb3r3 force-pushed the refactor-push-again branch from 820b9c3 to e4f8624 Compare June 29, 2021 11:51
@jina-bot jina-bot added size/M and removed size/S labels Jul 7, 2021
@jina-bot jina-bot added the area/testing This issue/PR affects testing label Jul 7, 2021
@hanxiao hanxiao merged commit bec0c1a into master Jul 7, 2021
@hanxiao hanxiao deleted the refactor-push-again branch July 7, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/resource size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numb3r3 @hanxiao @jina-bot
0