8000 feat: telemetry on flow creation by deepankarm · Pull Request #2798 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: telemetry on flow creation #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2021
Merged

feat: telemetry on flow creation #2798

merged 3 commits into from
Jun 29, 2021

Conversation

deepankarm
Copy link
Contributor
@deepankarm deepankarm commented Jun 29, 2021 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito

@deepankarm deepankarm requested a review from a team as a code owner June 29, 2021 10:06
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/flow labels Jun 29, 2021
@codecov
Copy link
codecov bot commented Jun 29, 2021 •
edited
Loading

Codecov Report

Merging #2798 (8e6019f) into master (bf06bb3) will decrease coverage by 0.16%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
- Coverage   87.34%   87.18%   -0.17%     
==========================================
  Files         137      137              
  Lines        9128     9144      +16     
==========================================
- Hits         7973     7972       -1     
- Misses       1155     1172      +17
Flag Coverage Δ
daemon 47.90% <87.50%> (+3.85%) ⬆️
jina 85.17% <87.50%> (-2.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 78.46% <86.66%> (-10.65%) ⬇️
jina/parsers/flow.py 100.00% <100.00%> (ø)
jina/jaml/parsers/flow/v1.py 49.01% <0.00%> (-45.10%) ⬇️
jina/clients/__init__.py 79.31% <0.00%> (-20.69%) ⬇️
jina/clients/mixin.py 84.84% <0.00%> (-15.16%) ⬇️
jina/peapods/pods/compound.py 79.25% <0.00%> (-8.89%) ⬇️
jina/jaml/parsers/__init__.py 92.68% <0.00%> (-7.32%) ⬇️
jina/peapods/runtimes/zmq/zed.py 88.44% <0.00%> (-4.89%) ⬇️
jina/clients/base/http.py 88.37% <0.00%> (-4.66%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf06bb3...8e6019f. Read the comment docs.

hanxiao
han 8000 xiao reviewed Jun 29, 2021
View reviewed changes
@hanxiao hanxiao merged commit c97eb8c into master Jun 29, 2021
@hanxiao hanxiao deleted the feat-flow-telemetry branch June 29, 2021 11:00
hanxiao added a commit that referenced this pull request Jun 29, 2021
@hanxiao
Revert "feat: telemetry on flow creation (#2798)"
d7dfb6a 
This reverts commit c97eb8c.
@hanxiao hanxiao mentioned this pull request Jun 29, 2021
Merged
hanxiao added a commit that referenced this pull request Jun 29, 2021
@hanxiao
Revert "feat: telemetry on flow creation (#2798)" (#2807)
5ec7543 
This reverts commit c97eb8c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao left review comments

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/flow size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepankarm @hanxiao @jina-bot
0