8000 fix(hubble): add --install-deps argument by numb3r3 · Pull Request #2784 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(hubble): add --install-deps argument #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2021
Merged

fix(hubble): add --install-deps argument #2784

merged 1 commit into from
Jun 28, 2021

Conversation

numb3r3
Copy link
Member
@numb3r3 numb3r3 commented Jun 28, 2021 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito

@numb3r3 numb3r3 requested review from hanxiao and nan-wang June 28, 2021 11:12
@numb3r3 numb3r3 requested a review from a team as a code owner June 28, 2021 11:12
@jina-bot jina-bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase component/resource labels Jun 28, 2021
@codecov
Copy link
codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #2784 (5b8fd4d) into master (a21bccf) will increase coverage by 2.19%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2784      +/-   ##
==========================================
+ Coverage   87.25%   89.45%   +2.19%     
==========================================
  Files         138      138              
  Lines        9103     9104       +1     
==========================================
+ Hits         7943     8144     +201     
+ Misses       1160      960     -200
Flag Coverage Δ
daemon 47.21% <0.00%> (+3.64%) ⬆️
jina 88.89% <25.00%> (+1.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/helper.py 56.52% <ø> (-0.47%) ⬇️
jina/hubble/hubapi.py 73.68% <0.00%> (-1.32%) ⬇️
jina/hubble/hubio.py 70.67% <0.00%> (ø)
jina/parsers/hubble/pull.py 100.00% <100.00%> (ø)
jina/peapods/runtimes/gateway/http/models.py 100.00% <0.00%> (+0.75%) ⬆️
jina/types/routing/table.py 93.26% <0.00%> (+0.96%) ⬆️
jina/peapods/zmq/__init__.py 86.00% <0.00%> (+1.78%) ⬆️
jina/helper.py 81.26% <0.00%> (+2.03%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 92.30% <0.00%> (+2.56%) ⬆️
jina/enums.py 95.40% <0.00%> (+2.87%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21bccf...5b8fd4d. Read the comment docs.

@numb3r3 numb3r3 requested a review from mapleeit June 28, 2021 11:51
@numb3r3 numb3r3 merged commit 3863719 into master Jun 28, 2021
@numb3r3 numb3r3 deleted the fix-hubble-cli branch June 28, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit mapleeit approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao

@nan-wang nan-wang Awaiting requested review from nan-wang

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numb3r3 @mapleeit @jina-bot
0