8000 fix(http): change default endpoints methods to post by hanxiao · Pull Request #2775 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(http): change default endpoints methods to post #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2021
Merged

fix(http): change default endpoints methods to post #2775

merged 2 commits into from
Jun 27, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 27, 2021 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito

@hanxiao hanxiao requested a review from a team as a code owner June 27, 2021 10:55
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Jun 27, 2021
@codecov
Copy link
codecov bot commented Jun 27, 2021 •
edited
Loading

Codecov Report

Merging #2775 (6b912ba) into master (83f81b2) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 6b912ba differs from pull request most recent head 803ee83. Consider uploading reports for the commit 803ee83 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2775      +/-   ##
==========================================
+ Coverage   89.36%   89.53%   +0.16%     
==========================================
  Files         138      138              
  Lines        9076     9077       +1     
==========================================
+ Hits         8111     8127      +16     
+ Misses        965      950      -15
Flag Coverage Δ
daemon 46.25% <0.00%> (-1.02%) ⬇️
jina 89.02% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/gateway/http/app.py 96.72% <100.00%> (+0.05%) ⬆️
jina/flow/base.py 88.91% <0.00%> (ø)
jina/peapods/runtimes/zmq/zed.py 93.33% <0.00%> (+0.88%) ⬆️
jina/peapods/runtimes/jinad/client.py 87.57% <0.00%> (+1.18%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 96.49% <0.00%> (+1.75%) ⬆️
jina/peapods/pods/compound.py 89.62% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f81b2...803ee83. Read the comment docs.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Jun 27, 2021
@hanxiao hanxiao merged commit 637367a into master Jun 27, 2021
@hanxiao hanxiao deleted the fix-http-default-methods branch June 27, 2021 11:40
sthagen added a commit to sthagen/jina-ai-jina that referenced this pull request Jun 27, 2021
@sthagen
Merge pull request #17 from jina-ai/master
4857c8c 
fix(http): change default endpoints methods to post (jina-ai#2775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

@BastinJafari BastinJafari Awaiting requested review from BastinJafari

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0