fix(core): add complex test for routing list #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
==========================================
+ Coverage 87.12% 88.03% +0.90%
==========================================
Files 138 138
Lines 9377 9377
==========================================
+ Hits 8170 8255 +85
+ Misses 1207 1122 -85
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
actually i belive #2500 is fixed due to https://github.com/jina-ai/jina/pull/2750/files#diff-d9002011181954eeec0b9b94a9d08f7bc8028338275a35bea7823aa07d08041dL33 |
d65b657 to
3605823
Compare
bwanglzu
reviewed
Jul 7, 2021
I checked its 3 seconds. Lets not mark it as slow as its rather nice to execute locally (no docker etc involved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test to verify that #2500 got fixed as a side effect of dynamic routing (#2551).
Not sure we need this test actually as part of the test suite, but I was writing it anyway to verify the behaviour and I think there are no other tests doing this.
┆Issue is synchronized with this Asana task by Unito