8000 test: add more tests by JoanFM · Pull Request #2727 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: add more tests #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

test: add more tests #2727

merged 1 commit into from
Jun 22, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 22, 2021 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito

@JoanFM JoanFM requested a review from a team as a code owner June 22, 2021 05:39
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Jun 22, 2021
@codecov
Copy link
codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #2727 (1993aaa) into master (0094bbf) will increase coverage by 7.39%.
The diff coverage is 83.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2727      +/-   ##
==========================================
+ Coverage   82.21%   89.61%   +7.39%     
==========================================
  Files         106      152      +46     
  Lines        7064     9356    +2292     
==========================================
+ Hits         5808     8384    +2576     
+ Misses       1256      972     -284
Flag Coverage Δ
daemon 48.27% <83.11%> (?)
jina 89.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.21% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 100.00% <ø> (ø)
jina/clients/asyncio.py 100.00% <ø> (ø)
jina/clients/base.py 79.00% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/http.py 95.12% <ø> (ø)
jina/clients/mixin.py 100.00% <ø> (ø)
jina/clients/request/__init__.py 100.00% <ø> (ø)
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21b04c...1993aaa. Read the comment docs.

maximilianwerk
maximilianwerk approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit faabcc0 into master Jun 22, 2021
@JoanFM JoanFM deleted the expand-test branch June 22, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk maximilianwerk approved these changes

@slettner slettner Awaiting requested review from slettner

Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @maximilianwerk @jina-bot
0