feat(hubble): add jina hub pull cli #2713
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2713 +/- ##
==========================================
+ Coverage 82.21% 89.14% +6.92%
==========================================
Files 106 155 +49
Lines 7064 9611 +2547
==========================================
+ Hits 5808 8568 +2760
+ Misses 1256 1043 -213
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Nan Wang <nan.wang@jina.ai>
jina/parsers/hubble/pull.py
Outdated
| 6D40 | gp.add_argument( | |
| '--docker', | ||
| action='store_true', | ||
| default=False, | ||
| help='If set, pull the Docker image from the Jina Hub registry', | ||
| ) |
There was a problem hiding this comment.
isn't id scheme already determined if it is docker or not?
id="jinahub+docker://..." -> --docker
id="jinahub://..." -> no --docker
then --docker is redundant
There was a problem hiding this comment.
Now, id in the argument refers to UUID8 only. jina hub pull {UUID8} will pull the uploaded executor package only.
So, here, the argument id should be used as the full uri path of the executor?
There was a problem hiding this comment.
jina hub pull {UUID8} will pull the uploaded executor package only.
- isn't this then
jinahub://{UUID} - how is it differed from
.add(uses="jinahub://uri")?
There was a problem hiding this comment.
I submitted a new commit. Now, we can directly pass URI of executor, jina hub pull jinahub(+docker)://{UUID8}
jina hub pull jinahub(+docker)://{UUID8}:{secret}jinahub+docker://{UUID8}in Flow, e.g.,jinahub://{UUID8}:{secret}in Flow┆Issue is synchronized with this Asana task by Unito