8000 fix(http): fix http request response model by hanxiao · Pull Request #2712 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(http): fix http request response model #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 21, 2021
Merged

fix(http): fix http request response model #2712

merged 9 commits into from
Jun 21, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 21, 2021

┆Issue is synchronized with this Asana task by Unito

@hanxiao hanxiao requested a review from a team as a code owner June 21, 2021 07:32
@hanxiao hanxiao requested review from mapleeit and jakobkruse1 June 21, 2021 07:32
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/client component/peapod labels Jun 21, 2021
@codecov
Copy link
codecov bot commented Jun 21, 2021

Codecov Report

Merging #2712 (c1e90d1) into master (158c3f0) will increase coverage by 1.46%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2712      +/-   ##
==========================================
+ Coverage   88.01%   89.48%   +1.46%     
==========================================
  Files         150      152       +2     
  Lines        9197     9354     +157     
==========================================
+ Hits         8095     8370     +275     
+ Misses       1102      984     -118     
Flag Coverage Δ
daemon 47.95% <2.85%> (+0.72%) ⬆️
jina 89.72% <97.14%> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/request/__init__.py 100.00% <ø> (ø)
jina/excepts.py 100.00% <ø> (ø)
jina/clients/http.py 90.24% <80.00%> (+3.75%) ⬆️
jina/peapods/runtimes/asyncio/http/app.py 96.66% <100.00%> (+1.58%) ⬆️
jina/peapods/runtimes/asyncio/http/models.py 100.00% <100.00%> (ø)
jina/flow/builder.py 88.88% <0.00%> (-7.37%) ⬇️
jina/enums.py 95.20% <0.00%> (-0.60%) ⬇️
jina/clients/base.py 77.00% <0.00%> (ø)
jina/proto/jina_pb2.py 100.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158c3f0...c1e90d1. Read the comment docs.

@hanxiao hanxiao merged commit f13c681 into master Jun 21, 2021
@hanxiao hanxiao deleted the fix-http-gateway branch June 21, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/client component/peapod size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0