8000 refactor: use RAII in Pods by JoanFM · Pull Request #2709 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: use RAII in Pods #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 38 commits into from
Closed

refactor: use RAII in Pods #2709

wants to merge 38 commits into from

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 21, 2021 •
edited by sync-by-unito bot
Loading

Based on #2688

┆Issue is synchronized with this Asana task by Unito

Joan Fontanals Martinez and others added 30 commits June 17, 2021 10:03
@deepankarm
fix: make or event picklable
ca8becf
@deepankarm
fix: make or event picklable
7ac07df
@deepankarm
fix: make or event picklable
0d61731
test: test show fix
220df21
fix: make it work for threads
3bf1e1f
fix: force setting spawn
39a42da
fix: remove set start from __init__
84e919f
Merge branch 'master' of https://github.com/jina-ai/jina into fix-all…
b4a61a0 
…ow-spawn
docs: add docstring
172a21b
fix: remove peatype
7a19ea6
Merge branch 'master' of https://github.com/jina-ai/jina into fix-all…
9608761 
…ow-spawn
fix: fix context manager
2ef46f6
feat: move runtime into run stack
2a373c9
refactor: remove ssh and zmqmany runtimes
08bbbf2
Merge branch 'remove-zmqmany-runtime' of https://github.com/jina-ai/jina
083e375 
 into fix-allow-spawn
refactor: refactor pea closure
8728d9f
fix: fix test pea
e483042
test: add github issue test
a544f05
docs: improve docstrings
26e6483
Merge branch 'master' of https://github.com/jina-ai/jina into fix-all…
de117b4 
…ow-spawn
fix: adapt the passing of control addresses
1879216
fix: fix activate
73a533e
refactor: raii in runtime, remove setup
f04f724
fix: clarify control addresses
0e82727
fix: move send terminate logic to pea
65a24eb
fix: proper port configuration
9ef37f8
refactor: raii pattern for pods
3526040
Merge branch 'master' of https://github.com/jina-ai/jina into fix-all…
0222bca 
…ow-spawn
Merge branch 'fix-allow-spawn' of https://github.com/jina-ai/jina int…
823f3b7 
…o raii-pods
@jina-bot jina-bot added size/L area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/logging component/peapod labels Jun 21, 2021
@codecov
Copy link
codecov bot commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #2709 (961fd57) into master (f107759) will decrease coverage by 1.06%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2709      +/-   ##
==========================================
- Coverage   87.34%   86.27%   -1.07%     
==========================================
  Files         150      150              
  Lines        9197     9190       -7     
==========================================
- Hits         8033     7929     -104     
- Misses       1164     1261      +97
Flag Coverage Δ
daemon 47.25% <31.03%> (+0.02%) ⬆️
jina 86.26% <86.20%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/compound.py 71.65% <77.77%> (-17.83%) ⬇️
jina/flow/base.py 60.21% <100.00%> (-14.95%) ⬇️
jina/peapods/pods/__init__.py 81.11% <100.00%> (-0.37%) ⬇️
jina/clients/base.py 73.00% <0.00%> (-1.00%) ⬇️
jina/peapods/runtimes/zmq/zed.py 86.32% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f107759...961fd57. Read the comment docs.

@JoanFM JoanFM changed the base branch from master to fix-allow-spawn June 21, 2021 06:14
@JoanFM JoanFM force-pushed the fix-allow-spawn branch from d65728f to 7b46273 Compare June 21, 2021 06:32
Base automatically changed from fix-allow-spawn to master June 21, 2021 06:51
@JoanFM JoanFM marked this pull request as ready for review June 21, 2021 06:54
@JoanFM JoanFM requested a review from a team as a code owner June 21, 2021 06:54
@JoanFM JoanFM marked this pull request as draft June 21, 2021 07:19
@JoanFM
Copy link
Contributor Author
JoanFM commented Jun 21, 2021

Problem
Problem caused by deepcopy used in Flow

@JoanFM JoanFM closed this Jun 21, 2021
@JoanFM JoanFM deleted the raii-pods branch July 20, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

@deepankarm deepankarm Awaiting requested review from deepankarm

@hanxiao hanxiao Awaiting requested review from hanxiao

@nan-wang nan-wang Awaiting requested review from nan-wang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/logging component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @jina-bot @deepankarm
0