10000 fix: return dict and no structview by JoanFM · Pull Request #2692 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: return dict and no structview #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

fix: return dict and no structview #2692

merged 1 commit into from
Jun 17, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 17, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner June 17, 2021 12:58
@JoanFM JoanFM requested review from jacobowitz and Kelton8Z June 17, 2021 12:58
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/type labels Jun 17, 2021
@codecov
Copy link
codecov bot commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #2692 (21c4f58) into master (5db3fb6) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
+ Coverage   89.36%   89.47%   +0.10%     
==========================================
  Files         147      147              
  Lines        9109     9109              
==========================================
+ Hits         8140     8150      +10     
+ Misses        969      959      -10
Flag Coverage Δ
daemon 47.75% <0.00%> (-0.03%) ⬇️
jina 89.70% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/request/__init__.py 98.31% <100.00%> (ø)
jina/helper.py 82.82% <0.00%> (ø)
jina/peapods/zmq/__init__.py 85.20% <0.00%> (+2.07%) ⬆️
jina/clients/base.py 82.00% <0.00%> (+3.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db3fb6...21c4f58. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jun 17, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1639, delta to last 1 avg.: -6%
  • 🐢🐢 query QPS at 68, delta to last 1 avg.: -10%

Breakdown

Version Index QPS Query QPS
current 1639 68
2.0.0rc6 1759 76

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM force-pushed the avoid-override-params branch from 53c9765 to 3f6e29d Compare June 17, 2021 13:19
@JoanFM JoanFM force-pushed the avoid-override-params branch from 3f6e29d to 21c4f58 Compare June 17, 2021 13:21
@JoanFM JoanFM requested review from bwanglzu and davidbp June 17, 2021 13:39
bwanglzu
bwanglzu approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoanFM JoanFM merged commit 44b70b6 into master Jun 17, 2021
@JoanFM JoanFM deleted the avoid-override-params branch June 17, 2021 13:44
JoanFM pushed a commit that referenced this pull request Jun 17, 2021
fix: return dict and no structview (#2692)
7911d7a
nan-wang pushed a commit that referenced this pull request Jun 18, 2021
feat: add listview (#2689)
f58592d 
* feat: add listview

* fix: update issue test

* feat: implement iterable dunder_get

* fix: add equality check

* fix: return dict and no structview (#2692)

* test: add complex tags integration test

* fix: fallback to proto sort if not valid interface (#2687)

* fix: fix last test

* fix: clarify types and naming
numb3r3 pushed a commit that referenced this pull request Jun 18, 2021
@numb3r3
fix: return dict and no structview (#2692)
c7a559a
numb3r3 pushed a commit that referenced this pull request Jun 18, 2021
@numb3r3
feat: add listview (#2689)
6fdfe8a 
* feat: add listview

* fix: update issue test

* feat: implement iterable dunder_get

* fix: add equality check

* fix: return dict and no structview (#2692)

* test: add complex tags integration test

* fix: fallback to proto sort if not valid interface (#2687)

* fix: fix last test

* fix: clarify types and naming
mapleeit pushed a commit that referenced this pull request Jun 21, 2021
@mapleeit
feat: add listview (#2689)
33e6c0a 
* feat: add listview

* fix: update issue test

* feat: implement iterable dunder_get

* fix: add equality check

* fix: return dict and no structview (#2692)

* test: add complex tags integration test

* fix: fallback to proto sort if not valid interface (#2687)

* fix: fix last test

* fix: clarify types and naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

@Kelton8Z Kelton8Z Awaiting requested review from Kelton8Z

@davidbp davidbp Awaiting requested review from davidbp

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/type size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @bwanglzu @jina-bot
0