8000 Modify the behavior of public and private by mapleeit · Pull Request #2672 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modify the behavior of public and private #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2021
Merged

Modify the behavior of public and private #2672

merged 3 commits into from
Jun 16, 2021

Conversation

mapleeit
Copy link
Contributor

CREATE operation at first time:

  • jina hub push . -> public or private, either is okey with me
  • jina hub push --public . -> public
  • jina hub push --private . -> private

UPDATE operation using --force option:

  • jina hub push --force UUID --secret SECRET . -> don't change visibility
  • jina hub push --private --force UUID --secret SECRET . -> change to private
  • jina hub push --public --force UUID --secret SECRET . -> change to public

@mapleeit mapleeit requested a review from a team as a code owner June 16, 2021 08:47
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Jun 16, 2021
@codecov
Copy link
codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #2672 (33a37f3) into master (0094bbf) will increase coverage by 7.06%.
The diff coverage is 83.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2672      +/-   ##
==========================================
+ Coverage   82.21%   89.28%   +7.06%     
==========================================
  Files         106      146      +40     
  Lines        7064     9003    +1939     
==========================================
+ Hits         5808     8038    +2230     
+ Misses       1256      965     -291
Flag Coverage Δ
daemon 48.27% <83.11%> (?)
jina 89.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.21% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 89.47% <ø> (ø)
jina/clients/asyncio.py 100.00% <ø> (ø)
jina/clients/base.py 79.00% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/mixin.py 100.00% <ø> (ø)
jina/clients/request/__init__.py 100.00% <ø> (ø)
jina/clients/request/asyncio.py 88.88% <ø> (ø)
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dbced...33a37f3. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jun 16, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1721, delta to last 1 avg.: +0%
  • 😶 query QPS at 58, delta to last 1 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1721 58
2.0.0rc6 1721 58

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit d2e62b9 into master Jun 16, 2021
@hanxiao hanxiao deleted the fix-hub-push branch June 16, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@JoanFM JoanFM Awaiting requested review from JoanFM

@numb3r3 numb3r3 Awaiting requested review from numb3r3

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapleeit @hanxiao @jina-bot
0