8000 fix: use relative path in archived executor package by numb3r3 · Pull Request #2676 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use relative path in archived executor package #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2021
Merged

fix: use relative path in archived executor package #2676

merged 4 commits into from
Jun 16, 2021

Conversation

numb3r3
Copy link
Member
@numb3r3 numb3r3 commented Jun 16, 2021

No description provided.

@numb3r3 numb3r3 added the area/core This issue/PR affects the core codebase label Jun 16, 2021
@numb3r3 numb3r3 requested a review from a team as a code owner June 16, 2021 11:24
@jina-bot jina-bot added size/S area/helper This issue/PR affects the helper functionality component/resource labels Jun 16, 2021
@codecov
Copy link
codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #2676 (8bc0ca5) into master (4273af8) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2676      +/-   ##
==========================================
+ Coverage   89.12%   89.28%   +0.15%     
==========================================
  Files         146      146              
  Lines        9002     9003       +1     
==========================================
+ Hits         8023     8038      +15     
+ Misses        979      965      -14
Flag Coverage Δ
daemon 48.26% <0.00%> (-0.01%) ⬇️
jina 89.49% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 82.71% <ø> (ø)
jina/hubble/helper.py 87.09% <100.00%> (+0.43%) ⬆️
jina/peapods/pods/__init__.py 85.49% <0.00%> (+0.90%) ⬆️
jina/peapods/pods/compound.py 90.97% <0.00%> (+1.50%) ⬆️
jina/peapods/peas/__init__.py 96.77% <0.00%> (+2.41%) ⬆️
jina/hubble/hubio.py 75.51% <0.00%> (+12.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4273af8...8bc0ca5. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jun 16, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1838, delta to last 1 avg.: +0%
  • 😶 query QPS at 78, delta to last 1 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1838 78
2.0.0rc6 1853 78

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 2e4e6fe into master Jun 16, 2021
@hanxiao hanxiao deleted the fix-hubble-archive branch June 16, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numb3r3 @hanxiao @jina-bot
0