8000 fix: clarify typehint for callback function by hanxiao · Pull Request #2667 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: clarify typehint for callback function #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2021
Merged

fix: clarify typehint for callback function #2667

merged 4 commits into from
Jun 16, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 16, 2021 •
edited
Loading

image

@hanxiao hanxiao requested a review from a team as a code owner June 16, 2021 01:24
@hanxiao hanxiao requested review from alanthssss and numb3r3 June 16, 2021 01:24
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client component/type labels Jun 16, 2021
@github-actions
Copy link
github-actions bot commented Jun 16, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1460, delta to last 1 avg.: +0%
  • 😶 query QPS at 49, delta to last 1 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1460 49
2.0.0rc6 1463 50

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #2667 (532d47a) into master (0094bbf) will increase coverage by 7.12%.
The diff coverage is 83.11%.

❗ Current head 532d47a differs from pull request most recent head 11a3da3. Consider uploading reports for the commit 11a3da3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2667      +/-   ##
==========================================
+ Coverage   82.21%   89.34%   +7.12%     
==========================================
  Files         106      146      +40     
  Lines        7064     8972    +1908     
==========================================
+ Hits         5808     8016    +2208     
+ Misses       1256      956     -300
Flag Coverage Δ
daemon 48.29% <83.11%> (?)
jina 89.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.76% <ø> (ø)
jina/checker.py 96.55% <ø> (ø)
jina/clients/__init__.py 89.47% <ø> (ø)
jina/clients/asyncio.py 100.00% <ø> (ø)
jina/clients/base.py 79.00% <ø> (ø)
jina/clients/grpc.py 100.00% <ø> (ø)
jina/clients/helper.py 100.00% <ø> (ø)
jina/clients/mixin.py 100.00% <ø> (ø)
jina/clients/request/__init__.py 100.00% <ø> (ø)
jina/clients/request/asyncio.py 88.88% <ø> (ø)
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2626c...11a3da3. Read the comment docs.

@jina-bot jina-bot added area/network This issue/PR affects network functionality component/flow component/peapod labels Jun 16, 2021
@jina-bot jina-bot added the area/housekeeping This issue/PR is housekeeping label Jun 16, 2021
@hanxiao hanxiao merged commit 5e18622 into master Jun 16, 2021
@hanxiao hanxiao deleted the fix-callback-type-hint branch June 16, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanthssss alanthssss Awaiting requested review from alanthssss

@numb3r3 numb3r3 Awaiting requested review from numb3r3

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/flow component/peapod component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0