8000 feat: let response handle primitive docs by JoanFM · Pull Request #2658 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: let response handle primitive docs #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

feat: let response handle primitive docs #2658

merged 1 commit into from
Jun 15, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 15, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner June 15, 2021 12:58
@JoanFM JoanFM requested review from davidbp and cristianmtr June 15, 2021 12:58
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Jun 15, 2021
@codecov
Copy link
codecov bot commented Jun 15, 2021

Codecov Report

Merging #2658 (c5e61fd) into master (61ee0c0) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2658      +/-   ##
==========================================
+ Coverage   89.08%   89.26%   +0.17%     
==========================================
  Files         146      146              
  Lines        8968     8969       +1     
==========================================
+ Hits         7989     8006      +17     
+ Misses        979      963      -16     
Flag Coverage Δ
daemon 48.31% <100.00%> (+<0.01%) ⬆️
jina 89.47% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/request/__init__.py 99.15% <100.00%> (+<0.01%) ⬆️
jina/types/request/data.py 77.77% <100.00%> (ø)
jina/flow/base.py 90.74% <0.00%> (+0.92%) ⬆️
jina/peapods/runtimes/zmq/zed.py 92.85% <0.00%> (+0.95%) ⬆️
jina/peapods/pods/compound.py 89.47% <0.00%> (+7.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ee0c0...c5e61fd. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1372, delta to last 1 avg.: +1%
  • 😶 query QPS at 42, delta to last 1 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 1372 42
2.0.0rc6 1356 41

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 449bf24 into master Jun 15, 2021
@hanxiao hanxiao deleted the response-mixins branch June 15, 2021 14:32
JoanFM pushed a commit that referenced this pull request Jun 15, 2021
hanxiao pushed a commit that referenced this pull request Jun 16, 2021
* feat: add scores and evaluations as maps

* feat: add scores and evaluations as maps

* docs: docstring for mapped scores

* feat: add iteration to mapped names

* test: fix some integration tests

* test: add test to memmap

* fix: fix system helloworld

* feat: implement mutablemapping

* refactor: update class name

* fix: fix hello worlds

* feat: let response handle primitive docs (#2658)

* test: hide my exec collide with other test (#2654)

* fix: fix distributed tests

* docs: update cookbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0