8000 fix: fix sparse pipeline test by JoanFM · Pull Request #2641 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix sparse pipeline test #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2021
Merged

fix: fix sparse pipeline test #2641

merged 1 commit into from
Jun 14, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 14, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner June 14, 2021 10:41
@JoanFM JoanFM requested review from jacobowitz and Kelton8Z June 14, 2021 10:41
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Jun 14, 2021
bwanglzu
bwanglzu approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #2641 (876bbf1) into master (f5bba5f) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
+ Coverage   88.33%   88.68%   +0.35%     
==========================================
  Files         148      148              
  Lines        8947     8947              
==========================================
+ Hits         7903     7935      +32     
+ Misses       1044     1012      -32
Flag Coverage Δ
daemon 48.40% <ø> (ø)
jina 88.86% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/asyncio/grpc/async_call.py 94.33% <0.00%> (-3.78%) ⬇️
jina/peapods/pods/__init__.py 85.49% <0.00%> (+0.90%) ⬆️
jina/flow/base.py 90.74% <0.00%> (+0.92%) ⬆️
jina/peapods/runtimes/zmq/zed.py 92.85% <0.00%> (+0.95%) ⬆️
jina/peapods/zmq/__init__.py 85.20% <0.00%> (+2.07%) ⬆️
jina/peapods/peas/__init__.py 96.77% <0.00%> (+2.41%) ⬆️
jina/clients/base.py 82.17% <0.00%> (+2.97%) ⬆️
jina/peapods/pods/compound.py 90.97% <0.00%> (+9.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bba5f...876bbf1. Read the comment docs.

@JoanFM JoanFM merged commit 6346e84 into master Jun 14, 2021
@JoanFM JoanFM deleted the fix-sparse-pipeline-test branch June 14, 2021 11:36
numb3r3 pushed a commit that referenced this pull request Jun 15, 2021
@numb3r3
fix: fix sparse pipeline test (#2641)
d12322a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

@Kelton8Z Kelton8Z Awaiting requested review from Kelton8Z

Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @bwanglzu @jina-bot
0