8000 refactor(flow): remove asyncflow class by hanxiao · Pull Request #2616 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(flow): remove asyncflow class #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2021
Merged

refactor(flow): remove asyncflow class #2616

merged 4 commits into from
Jun 10, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 10, 2021

AsyncFlow is now simply Flow(asyncio=True)

@hanxiao hanxiao requested a review from a team as a code owner June 10, 2021 15:47
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/flow component/jaml labels Jun 10, 2021
@codecov
Copy link
codecov bot commented Jun 10, 2021 •
edited
Loading

Codecov Report

Merging #2616 (3b026d4) into master (53908f8) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 3b026d4 differs from pull request most recent head cf1ce3b. Consider uploading reports for the commit cf1ce3b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
+ Coverage   88.44%   88.61%   +0.17%     
==========================================
  Files         148      147       -1     
  Lines        8950     8945       -5     
==========================================
+ Hits         7916     7927      +11     
+ Misses       1034     1018      -16
Flag Coverage Δ
daemon 48.39% <83.33%> (+<0.01%) ⬆️
jina 88.79% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 83.08% <ø> (ø)
jina/jaml/__init__.py 94.79% <ø> (ø)
jina/schemas/flow.py 100.00% <ø> (ø)
jina/flow/base.py 90.74% <100.00%> (+0.18%) ⬆️
jina/peapods/pods/__init__.py 85.49% <0.00%> (+0.90%) ⬆️
jina/peapods/pods/compound.py 90.97% <0.00%> (+1.50%) ⬆️
jina/peapods/peas/__init__.py 96.77% <0.00%> (+2.41%) ⬆️
jina/clients/__init__.py 89.47% <0.00%> (+10.52%) ⬆️
jina/clients/asyncio.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53908f8...cf1ce3b. Read the comment docs.

@jina-bot jina-bot added the area/docs This issue/PR affects the docs label Jun 10, 2021
@hanxiao hanxiao merged commit d97fe0c into master Jun 10, 2021
@hanxiao hanxiao deleted the refactor-rm-asyncflow branch June 10, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/flow component/jaml size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0